Skip ConsentPane image loading in preview to fix flakiness - #13172
Merged
josephroque-stripe merged 1 commit intoJun 1, 2026
Conversation
josephroque-stripe
force-pushed
the
josephroque/fix/consent-pane-screenshots
branch
from
June 1, 2026 21:29
c29a564 to
bf30b35
Compare
mindy-stripe
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
LaunchedEffectin preview mode to prevent fallback images sometimes being rendered in snapshot tests, leading to flakiness. By skipping this attempted load entirely in previews, we ensure we keep consistent screenshots.Once this merges, we can remove these screenshots from the quarantine. They won't run in this PR due to the quarantine
Motivation
https://jira.corp.stripe.com/browse/RUN_LINK_MOBILE-176
Testing
Screenshots
Changelog