StripeCryptoOnramp: Adds a Number of E2E Tests for Onramp - #13524
Open
Twigz wants to merge 11 commits into
Open
Conversation
jeanregisser
reviewed
Aug 5, 2026
jeanregisser
left a comment
jeanregisser
left a comment
Member
There was a problem hiding this comment.
Great improvements 🚀 Couple of small questions below.
| .around(composeRule) | ||
| .around(attestationFeatureFlagTestRule) | ||
| .around(fixtureRule) | ||
| .around(activityRule) |
Member
There was a problem hiding this comment.
We dropped the RetryRule(3) that the old test had. These flows flake pretty easily (OTP, network, external steps) - was that on purpose, or worth keeping?
Collaborator
Author
There was a problem hiding this comment.
That was a miss, put it back.
| } | ||
|
|
||
| private fun hideKeyboard() { | ||
| device.pressBack() |
Member
There was a problem hiding this comment.
device.pressBack() can pop the screen if the keyboard isn't actually up. Could we use Espresso.closeSoftKeyboard() like the rest of the repo? It's a no-op when there's no keyboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds E2E Onramp tests to prevent future failures.
Motivation
Adds more coverage to make sure future improvements don't cause failures.
Testing