Tyler/payment config phase 6 - #13645
Draft
tjclawson-stripe wants to merge 54 commits into
Draft
Conversation
tjclawson-stripe
force-pushed
the
tyler/payment-config-phase-6
branch
30 times, most recently
from
July 29, 2026 21:26
4bd2a87 to
f57ac68
Compare
Every Dagger-injected instance of ApiConfiguration.State is now () -> ApiConfiguration.State. This eliminates all possible eager resolution at component construction time. Deleted ApiConfigurationStateFromProviderModule — no longer needed since nothing injects ApiConfiguration.State directly from Dagger. Classes updated: - PaymentAnalyticsRequestFactory (@Inject constructor) - DefaultPaymentNextActionHandlerRegistry (@Inject constructor) - PaymentLauncherModule (@provides) - CustomerSheetViewModel (constructor) - AttestationComponent (@BindsInstance) - AutocompleteViewModelFactoryComponent (@BindsInstance) - AddressElementViewModelFactoryComponent (@BindsInstance) - TapToAddCollectionHandler / TapToAddModule Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
tjclawson-stripe
force-pushed
the
tyler/payment-config-phase-6
branch
from
August 4, 2026 18:30
8c7135d to
6e78fa8
Compare
…er<> CryptoApiRepository and OnrampModule now use the function type consistently with the rest of the codebase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
Add stripeAccountId parameter to CustomerRepository.getPaymentMethods() so PaymentElementLoader can pass the already-resolved value from ApiConfigurationResolver during prefetch (before metadata exists). Also fix test Dagger components missing () -> ApiConfiguration.State bindings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
…untId explicitly Every method in CustomerRepository now takes stripeAccountId: String? as a required parameter (no default). Callers pass it from their own resolved ApiConfiguration.State. This eliminates the dependency on ApiConfigurationModule for pre-load operations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
…nfiguration() This provides ApiConfiguration.State from the Link config's publishableKey and stripeAccountId, eliminating the fallback to PaymentConfiguration.getInstance() in ApiConfigurationResolver for the onramp/Link controller flow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
…ller.configure() The onramp flow previously relied on LinkController.configure() calling PaymentConfiguration.init() as a side effect. That call was removed during the ApiConfiguration migration. Initialize it explicitly here since the onramp has the publishable key available from its own config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Screenshots
Changelog