Share automatic-tax billing address primitives (MOBILESDK-4667) - #13717
Merged
Conversation
This was referenced Aug 3, 2026
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
2 times, most recently
from
August 3, 2026 20:06
6a83cba to
cbf2e78
Compare
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
2 times, most recently
from
August 3, 2026 20:22
2ca18e7 to
ec9398c
Compare
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
2 times, most recently
from
August 3, 2026 21:58
adfe109 to
1265162
Compare
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
2 times, most recently
from
August 3, 2026 23:46
354f22e to
924554b
Compare
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
from
August 4, 2026 18:16
bca787f to
06aa548
Compare
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
from
August 4, 2026 19:26
06aa548 to
0c2381a
Compare
cttsai-stripe
marked this pull request as ready for review
August 4, 2026 22:18
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
from
August 4, 2026 22:18
0c2381a to
f2ccba5
Compare
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
from
August 4, 2026 22:34
f2ccba5 to
57dc676
Compare
amk-stripe
reviewed
Aug 4, 2026
| CountryConfig(countryCodes), | ||
| rawValuesMap[IdentifierSpec.Country] | ||
| ), | ||
| countryElementIdentifier: IdentifierSpec, |
Collaborator
There was a problem hiding this comment.
why did we introduce this parameter? Looks like it's always set to IdentifierSpec.Country so seems unnecessary. Can we revert?
Contributor
Author
There was a problem hiding this comment.
Deferred to later PRs.
Base automatically changed from
cttsai/mobilesdk-4667-stable-tax-billing-signal
to
master
August 4, 2026 23:20
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
from
August 4, 2026 23:20
57dc676 to
5b971dd
Compare
Contributor
|
Diffuse output: APKDEX |
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
2 times, most recently
from
August 5, 2026 00:18
57dc676 to
eea2b61
Compare
amk-stripe
approved these changes
Aug 5, 2026
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
cttsai-stripe
force-pushed
the
cttsai/mobilesdk-4667-shared-tax-address
branch
from
August 5, 2026 16:51
eea2b61 to
defc3de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename and generalize the card billing-address element as
BillingAddressElement, with explicit collection modes for no address, full address, and country-first collection.Card behavior is unchanged.
cardBillingAddressCollectionModeretains Automatic-mode AVS postal-code collection for US, GB, and CA, then additively applies the Checkout Session automatic-tax requirements when applicable. The implementation uses an API-23-compatible map update.This PR deliberately keeps the nested country element at
IdentifierSpec.Country. It does not addcountryElementIdentifieror change card call sites. #13723 adds that required parameter whenCountrySpecfirst needs its own API path.Motivation
Card Automatic collection is not a safe default for a country-only LPM because it asks for postal code in the US, GB, and CA even when automatic tax is disabled. Separating the card policy from generic country-first collection keeps that LPM work in the following PRs.
No automatic-tax policy, saved-PM behavior, or saved-card-editing behavior changes in this PR.
Testing
CardBillingAddressElementTestcovers retained card AVS behavior, additive automatic-tax fields, country-only collection without AVS defaults, Full collection, and country changes. Focused verification passed:./gradlew :payments-ui-core:lintRelease :payments-ui-core:detekt :payments-ui-core:apiCheck :payments-ui-core:testDebugUnitTest :paymentsheet:lintRelease :paymentsheet:detekt :paymentsheet:apiCheck :paymentsheet:testDebugUnitTestScreenshots
N/A: refactor only.
Changelog
N/A: internal/library-group implementation.