Use PaymentSheetTopBarStateFactory in EmbeddedNavigator screens - #13790
Open
jaynewstrom-stripe wants to merge 1 commit into
Open
Use PaymentSheetTopBarStateFactory in EmbeddedNavigator screens#13790jaynewstrom-stripe wants to merge 1 commit into
jaynewstrom-stripe wants to merge 1 commit into
Conversation
Base automatically changed from
jaynewstrom/payment-method-title-helper
to
master
August 6, 2026 16:15
Form, VerticalPaymentOptions, and HorizontalPaymentOptions each hand-rolled an identical PaymentSheetTopBarState where only the test-mode label varied. Route them through PaymentSheetTopBarStateFactory.create with Editable.Never, matching how PaymentSheetScreen's add-payment-method screens build their top bar state. Behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
jaynewstrom-stripe
force-pushed
the
jaynewstrom/embedded-navigator-topbar-factory
branch
from
August 6, 2026 16:15
18ad335 to
c049765
Compare
jaynewstrom-stripe
marked this pull request as ready for review
August 6, 2026 16:20
amk-stripe
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
PaymentSheetTopBarStateFactory.createfor the embedded Form, VerticalPaymentOptions, and HorizontalPaymentOptions screens instead of manually constructing identicalPaymentSheetTopBarStatevalues.Motivation
Centralize top bar state construction and keep these embedded screens consistent with PaymentSheet's add-payment-method screens. This removes duplicated state setup while preserving existing behavior.
Testing
Not run; this is a behavior-preserving refactor.
Screenshots
N/A — no visual changes.
Changelog
No changelog entry; this is an internal refactor with no user-facing behavior changes.