Deliver CheckoutController confirmation results - #13802
Draft
jaynewstrom-stripe wants to merge 2 commits into
Draft
Conversation
jaynewstrom-stripe
requested review from
toluo-stripe
and removed request for
a team
August 6, 2026 19:19
jaynewstrom-stripe
marked this pull request as draft
August 6, 2026 19:21
jaynewstrom-stripe
force-pushed
the
jaynewstrom/checkout-controller-confirmation-results
branch
from
August 6, 2026 19:49
5447187 to
f37a3dc
Compare
3 tasks
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckoutController.Resultcallbacks.Result.Completedfor completion.Stack position: 3 of 5, based on #13801.
Motivation
CheckoutController.Builder.resultCallbackwas bound into the component but terminal confirmation results were not forwarded to it. Centralizing the mapping gives the controller one exactly-once result path and preserves the distinction between merchant-visible cancellation and returning to payment details.Testing
Added tests
Modified tests
Manually verified
./gradlew :paymentsheet:testDebugUnitTest --tests com.stripe.android.checkout.CheckoutConfirmationResultHandlerTest --tests com.stripe.android.checkout.CheckoutControllerTest./gradlew :paymentsheet-example:compileBaseDebugKotlinNo tests were ignored.
Screenshots
Not applicable — there are no visual changes.
Changelog
Not included —
CheckoutControllerremains a preview API.