Clear CheckoutController state after completion - #13804
Draft
jaynewstrom-stripe wants to merge 1 commit into
Draft
Conversation
jaynewstrom-stripe
requested review from
samer-stripe
and removed request for
a team
August 6, 2026 19:19
jaynewstrom-stripe
marked this pull request as draft
August 6, 2026 19:21
jaynewstrom-stripe
force-pushed
the
jaynewstrom/checkout-controller-clear-completed-state
branch
from
August 6, 2026 19:49
69b0cf5 to
856eeb5
Compare
jaynewstrom-stripe
force-pushed
the
jaynewstrom/checkout-controller-clear-completed-state
branch
from
August 6, 2026 21:37
856eeb5 to
4daf3a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckoutControllerstate after the serialized confirmation refresh and before deliveringResult.Completed.sessionflow returns tonullafter a completed payment flow.Stack position: 5 of 5 (top), based on #13803.
Motivation
A successfully completed payment flow should not leave a stale Checkout Session available for further mutation or reuse. Clearing after the best-effort refresh preserves confirmation ordering while ensuring observers and the result callback see the controller in its terminal state.
Testing
./gradlew :paymentsheet:testDebugUnitTest --tests com.stripe.android.checkout.CheckoutSheetLauncherTest --tests com.stripe.android.paymentelement.confirmation.intent.CheckoutSessionConfirmationInterceptorTest --tests com.stripe.android.checkout.CheckoutConfirmationResultHandlerTest --tests com.stripe.android.checkout.CheckoutConfirmationStateUpdaterTest --tests com.stripe.android.checkout.CheckoutControllerTestNo tests were ignored.
Screenshots
Not applicable — there are no visual changes.
Changelog
Not included —
CheckoutControllerremains a preview API.