Collect automatic tax billing addresses for non-card LPM forms - #13820
Draft
cttsai-stripe wants to merge 4 commits into
Draft
Collect automatic tax billing addresses for non-card LPM forms#13820cttsai-stripe wants to merge 4 commits into
cttsai-stripe wants to merge 4 commits into
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Contributor
|
Diffuse output: APKDEXARSC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Checkout automatic tax uses the billing address and the merchant selects Automatic address collection, new non-card LPM forms now collect the country-specific minimum billing address fields needed for tax.
What changed
flowchart LR S[Resolved LPM form] --> D{Existing address shape} D -->|Normal address| K[Keep one normal address] D -->|Canonical country only| P[Promote to tax-minimum address] D -->|No address| A[Add tax-minimum address before footer]What stays the same
Motivation
Some non-card LPM forms collect only country or no billing address in Automatic mode. A Checkout Session that calculates tax from billing details can then require an address without providing fields that satisfy the requirement.
Testing
Focused tests passed:
:payments-ui-core:testDebugUnitTest, filtered toAutomaticTaxBillingFieldsTest.:paymentsheet:testDebugUnitTest, filtered to resolver, builder, Klarna, Wero, Blik, and registry tests../gradlew :payments-ui-core:detekt :paymentsheet:detekt :paymentsheet-example:detekt :paymentsheet-example:assembleDebug.FormElementsBuilderTestplus:paymentsheet:detekt../gradlew :paymentsheet-example:detekt :paymentsheet-example:assembleDebugafter the Cash App example correction.git diff --check.Manual Cash App verification:
tax_meta.statuswascomplete.automatic_tax_taxability_reason = not_collectingandtaxable_amount = 0. This reflects the playground account's tax registration, not SDK address collection.Screenshots
Not included. The form behavior was verified manually and with focused form-shape tests.
Changelog