Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose 1.6 round two #9345

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed             │           uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff      
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
      dex │   1.9 MiB │     2 MiB │ +32.2 KiB │     4 MiB │   4.1 MiB │   +60 KiB 
     arsc │     1 MiB │     1 MiB │ +27.8 KiB │     1 MiB │     1 MiB │ +27.8 KiB 
 manifest │   2.3 KiB │   2.3 KiB │       0 B │     8 KiB │     8 KiB │       0 B 
      res │ 301.5 KiB │ 301.8 KiB │    +310 B │   455 KiB │ 455.5 KiB │    +520 B 
   native │   6.2 MiB │   6.2 MiB │       0 B │  15.8 MiB │  15.8 MiB │       0 B 
    asset │   6.8 KiB │     7 KiB │    +224 B │   6.5 KiB │   6.8 KiB │    +224 B 
    other │  85.5 KiB │  85.5 KiB │     -28 B │ 158.7 KiB │ 158.7 KiB │       0 B 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
    total │   9.5 MiB │   9.6 MiB │ +60.4 KiB │  21.4 MiB │  21.5 MiB │ +88.5 KiB 

 DEX     │ old   │ new   │ diff                 
─────────┼───────┼───────┼──────────────────────
   files │     1 │     1 │    0                 
 strings │ 20244 │ 20070 │ -174 (+3123 -3297)   
   types │  6082 │  6192 │ +110 (+2657 -2547)   
 classes │  4886 │  4984 │  +98 (+2426 -2328)   
 methods │ 29462 │ 30113 │ +651 (+20872 -20221) 
  fields │ 17389 │ 17545 │ +156 (+16001 -15845) 

 ARSC    │ old  │ new  │ diff         
─────────┼──────┼──────┼──────────────
 configs │  164 │  164 │   0          
 entries │ 3608 │ 3624 │ +16 (+17 -1)
APK
      compressed      │     uncompressed     │                                                   
──────────┬───────────┼──────────┬───────────┤                                                   
 size     │ diff      │ size     │ diff      │ path                                              
──────────┼───────────┼──────────┼───────────┼───────────────────────────────────────────────────
    2 MiB │ +32.2 KiB │  4.1 MiB │   +60 KiB │ ∆ classes.dex                                     
    1 MiB │ +27.8 KiB │    1 MiB │ +27.8 KiB │ ∆ resources.arsc                                  
    551 B │    +551 B │    828 B │    +828 B │ + res/-8.xml                                      
          │    -259 B │          │    -308 B │ - res/zn.xml                                      
  6.2 KiB │    +185 B │  6.1 KiB │    +185 B │ ∆ assets/dexopt/baseline.prof                     
    127 B │    +127 B │      5 B │      +5 B │ + META-INF/services/y4.y                          
    127 B │    +127 B │      5 B │      +5 B │ + META-INF/services/z4.a                          
          │    -127 B │          │      -5 B │ - META-INF/services/t4.y                          
          │    -127 B │          │      -5 B │ - META-INF/services/u4.a                          
    833 B │     +39 B │    701 B │     +39 B │ ∆ assets/dexopt/baseline.profm                    
 28.3 KiB │     -21 B │ 62.6 KiB │       0 B │ ∆ META-INF/CERT.SF                                
    525 B │      +7 B │    840 B │       0 B │ ∆ res/bt.xml                                      
 25.1 KiB │      -6 B │ 62.5 KiB │       0 B │ ∆ META-INF/MANIFEST.MF                            
  1.1 KiB │      -4 B │  2.7 KiB │       0 B │ ∆ res/L-.xml                                      
    303 B │      +2 B │    352 B │       0 B │ ∆ res/-5.xml                                      
    903 B │      -2 B │    2 KiB │       0 B │ ∆ res/2j.xml                                      
    460 B │      +2 B │    652 B │       0 B │ ∆ res/4I.xml                                      
    465 B │      +2 B │    656 B │       0 B │ ∆ res/5l.xml                                      
    541 B │      -2 B │    864 B │       0 B │ ∆ res/V1.xml                                      
    530 B │      +2 B │    984 B │       0 B │ ∆ res/aT.xml                                      
    438 B │      -2 B │    816 B │       0 B │ ∆ res/fg.xml                                      
    541 B │      -2 B │    864 B │       0 B │ ∆ res/hP.xml                                      
    582 B │      +2 B │  1.2 KiB │       0 B │ ∆ res/mA.xml                                      
    271 B │      -1 B │    120 B │       0 B │ ∆ META-INF/version-control-info.textproto         
    370 B │      -1 B │    476 B │       0 B │ ∆ res/1R.xml                                      
    764 B │      -1 B │  1.9 KiB │       0 B │ ∆ res/2f.xml                                      
    636 B │      +1 B │  1.2 KiB │       0 B │ ∆ res/2n.xml                                      
    597 B │      +1 B │    1 KiB │       0 B │ ∆ res/3A.xml                                      
    477 B │      +1 B │    780 B │       0 B │ ∆ res/46.xml                                      
    584 B │      +1 B │  1.1 KiB │       0 B │ ∆ res/5y.xml                                      
    413 B │      +1 B │    592 B │       0 B │ ∆ res/68.xml                                      
    760 B │      -1 B │  1.6 KiB │       0 B │ ∆ res/A0.xml                                      
    989 B │      -1 B │  2.7 KiB │       0 B │ ∆ res/AE.xml                                      
    932 B │      -1 B │  2.6 KiB │       0 B │ ∆ res/Be.xml                                      
    563 B │      +1 B │  1.5 KiB │       0 B │ ∆ res/G2.xml                                      
    367 B │      +1 B │    588 B │       0 B │ ∆ res/GT.xml                                      
    366 B │      +1 B │    464 B │       0 B │ ∆ res/Hd.xml                                      
    302 B │      +1 B │    352 B │       0 B │ ∆ res/K2.xml                                      
    413 B │      +1 B │    592 B │       0 B │ ∆ res/LT.xml                                      
    321 B │      +1 B │    484 B │       0 B │ ∆ res/NM.xml                                      
    413 B │      +1 B │    596 B │       0 B │ ∆ res/R2.xml                                      
    408 B │      +1 B │    592 B │       0 B │ ∆ res/S6.xml                               
...✂
DEX
STRINGS:

   old   │ new   │ diff               
  ───────┼───────┼────────────────────
   20244 │ 20070 │ -174 (+3123 -3297) 
  
  + 
              |
  + 
  ]
  +  (reason=
  +  in the map
  +  int arguments (
  +  ints and 
  +  object arguments (
  +  objects.
  +  without arguments because it expects 
  +  ∪ 
  + (this)
  + ) and 
  + ) is not null
  + ) is out of bounds [0,
  + ) is out of range. Each dimension must be between 0 and 16777215.
  + ) or end(
  + ), currentThread={id=
  + ), prevOffset=
  + ,
  
  + ,
  KeepUntilTransitionsFinished - 
  + , anchor=
  + , applied=
  + , arrangementSpacing=
  + , blendMode=
  + , but was 
  + , converter=
  + , crossAxisSize=
  + , crossed=
  + , disposed=
  + , effectsMap=
  + , endPosition=
  + , exit=
  + , graphicsLayerBlock=
  + , hold=
  + , horizontalArrangement=
  + , info=
  
  + , infos=
  + , isShowingSubstitution=
  + , layoutCache=
  + , lowestPin=
  + , originalEventPosition=
  + , overrideDescendants=
  + , platformImeOptions=null)
  + , propagateMinConstraints=
  + , range=(
  + , sizeAnimation=null, offsetAnimation=null, slideAnimation=null, enter=
  + , slide=null, changeSize=null, scale=
  + , spec: 
  + , startPosition=
  + , substitution=
  + , target: 
  + , toDpValues=
  + , verticalArrangement=
  + , visible=
  + ,deviceId=
  + . Not all arguments were provided. Missing 
  + >(TT;
  + A1
  + A2.o
  + AccessibilityKey: 
  + ActiveParent with no focused child
  + Already pushed argument 
  + AnimationVector3D: v1 = 
  + Array lengths must match and be nonzero
  + Array size not a multiple of 3
  + Asking for intrinsic measurements of SubcomposeLayout layouts is not supported. This includes components that are built on top of SubcomposeLayout, such as lazy lists, BoxWithConstraints, TabRow, etc. To mitigate this:
  - if intrinsic measurements are used to achieve 'match parent' sizing, consider replacing the parent of the component with a custom layout which controls the order in which children are measured, making intrinsic measurement not needed
  - adding a size modifier to the component, in order to fast return the queried intrinsic measurement.
  + B1
  + BlendModeColorFilter(color=
  + BoxMeasurePolicy(alignment=
  + Built-in alpha
  + Built-in scale
  + COLLAPSED
  + CROSSED
  + Call next() before removing an element.
  + Can only update the current state with MutableTransitionState
  + CancelTraversal
  + Cannot call set before the first call to next() or previous() or immediately after a call to add() or remove()
  + Cannot disable reuse from root if it was caused by other groups
  + Cannot end node insertion, there are no pending operations that can be realized.
  + Cannot find value for key 
  + Cannot pop(), because the stack is empty.
  + Cannot push 
  + Capacity must be a positive value.
  + Clear is not valid on OffsetApplier
  + ClearTextSubstitution
  + Compose:deactivate
  + Composition is disposed while composing. If dispose is triggered by a call in @Composable function, consider wrapping it with SideEffect block.
  + ContinueTraversal
  + Could not resolve state for movable content
  + Current selectable should have layout coordinates.
  + Deactivated node is focused
  + DensityWithConverter(density=
  + DepthSortedSet.add called on an unattached node
  + DepthSortedSet.remove called on an unattached node
  + Detected multithreaded access to SnapshotStateObserver: previousThreadId=
  + EnterExitTransitionElement(transition=
  + Error attempting to load resource: 
  + Error while pushing 
  + Error: Placement happened before lookahead.
  + Error: currentPostLookaheadIndex cannot be greater than the size of thepostLookaheadComposedSlotIds list.
  + Error: requestLookaheadRemeasure cannot be called on a node outside LookaheadScope
  + ExitTransition.KeepUntilTransitionsFinished
  + Expected AndroidViewHolder to be attached when observing reads.
  + Expected index to be within 0..size()-1, but was 
  + FFLL
  + FIFFF
  + FIZZZ
  + FLF
  + FixupList has pending fixup operations that were not realized. Were there mismatched insertNode() and endNodeInsert() calls?
  + FontScaleConverter{fromSpValues=
  + HorizontalCrossAxisAlignment(horizontal=
  + Hyphens.Unspecified
  + IIILJL
  + IJL
  + Insets(left=
  + InsetsPaddingValues(insets=
  + IntParameter(
  + IntRef(element = 
  + Invalid root
  + Invalid selectableId: 
  + IsShowingTextSubstitution
  + Item is not in pre-composed item range
  + JJLFL
  + JLF
  + JLIZZ
  + JLLJZZLZ
  +
...✂
ARSC
ENTRIES:

   old  │ new  │ diff         
  ──────┼──────┼──────────────
   3608 │ 3624 │ +16 (+17 -1) 
  + attr/indicatorTrackGapSize
  + attr/showMarker
  + attr/thumbHeight
  + attr/thumbTrackGapSize
  + attr/thumbWidth
  + attr/trackInsideCornerSize
  + attr/trackStopIndicatorSize
  + dimen/m3_carousel_small_item_size_max
  + dimen/m3_carousel_small_item_size_min
  + dimen/m3_comp_scrim_container_opacity
  + drawable/indeterminate_static
  + id/escape
  + id/transition_clip
  + id/transition_image_transform
  + id/transition_pause_alpha
  + string/tooltip_description
  + string/tooltip_label
  
  - xml/image_share_filepaths

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.6-round-two branch 2 times, most recently from 509107e to f4213cc Compare September 26, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant