Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crypto to PaymentSheet #4480

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

ericzhang-stripe
Copy link
Contributor

Summary

Add Crypto to PaymentSheet

Motivation

Add Crypto to PaymentSheet

Testing

Added tests + tested with Basic Non-Card Payment Examples project

Changelog

See diff

@ericzhang-stripe ericzhang-stripe requested review from a team as code owners January 17, 2025 23:05
@ericzhang-stripe ericzhang-stripe force-pushed the ericzhang-crypto-payment-sheet branch from 30c8a8a to defc490 Compare January 24, 2025 20:14
@ericzhang-stripe ericzhang-stripe force-pushed the ericzhang-crypto-payment-sheet branch from defc490 to 241edc4 Compare February 3, 2025 04:29
Copy link

⚠️ Public API changes detected:

StripeCore

- public func caseInsensitiveContains(_ other: Swift.String) -> Swift.Bool
+ @discardableResult
- public mutating func remove(_ element: Element) -> Element?

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

davidme-stripe
davidme-stripe previously approved these changes Feb 10, 2025
@ericzhang-stripe ericzhang-stripe force-pushed the ericzhang-crypto-payment-sheet branch 2 times, most recently from 55b5eec to 1abb3db Compare February 25, 2025 20:39
@ericzhang-stripe ericzhang-stripe force-pushed the ericzhang-crypto-payment-sheet branch from a0db855 to b4541a8 Compare February 26, 2025 00:42
@ericzhang-stripe ericzhang-stripe merged commit 2698c53 into master Feb 26, 2025
5 of 6 checks passed
@ericzhang-stripe ericzhang-stripe deleted the ericzhang-crypto-payment-sheet branch February 26, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants