Refactor DownloadManager image loading and caching - #6845
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
5 modified, 0 added
StripePaymentSheetPublic API-import CoreGraphicsIf you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
DownloadManager.swift:92 warning: Unused function 'clearCache()'This dead code check has been bypassed with the ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with [find-dead-code] |
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
1 modified, 0 added
## Summary Ignores regular import lines when diffing generated public Swift interfaces. For example, #6845 reports the removal of import CoreGraphics as a public API change even though it doesn’t change the API exposed to SDK users. ## Motivation #6845 ## Testing - Ruby syntax check - Verified regular imports are filtered while exported imports remain in the diff ## Changelog N/A Co-authored-by: codex <noreply@openai.com>
…ager-refactor Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> # Conflicts: # StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentMethodType.swift # StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/PaymentSheetPaymentMethodTypeTest.swift
…' into porter/download-manager-refactor
There was a problem hiding this comment.
seems previously broken
Summary
Refactors DownloadManager around a Swift async image-loading API with separate decoded-image and URL response caches. Payment method image consumers now use an immediately available cached image for initial rendering and an async load when the remote image is needed, with cancellation on cell reuse. The follow-up preserves synchronous promotion of URLCache images and the existing 1x1 transparent fallback behavior.
Motivation
Simplify image loading and caching
Testing
ci_scripts/run_tests.rb --test StripePaymentSheetTests/DownloadManagerTest --test StripePaymentSheetTests/STPPaymentMethodCardArtImageTest --test StripePaymentSheetTests/PaymentSheetPaymentMethodTypeTestChangelog
N/A