Fix flaky autocomplete billing address flowController UI tests 🪿✨ - #6861
Open
joyceqin-stripe wants to merge 3 commits into
Open
Fix flaky autocomplete billing address flowController UI tests 🪿✨#6861joyceqin-stripe wants to merge 3 commits into
joyceqin-stripe wants to merge 3 commits into
Conversation
Use waitForExistenceAndTap() instead of tap() for continueButton to ensure the button is hittable before tapping, and increase the confirmButton timeout to 10 seconds to account for sheet dismiss animation and async work completing. Committed-By-Agent: goose
joyceqin-stripe
marked this pull request as ready for review
August 6, 2026 19:18
joyceqin-stripe
enabled auto-merge (squash)
August 7, 2026 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minion run
Summary
In
testCard_AutocompleteBillingAddress_flowControllerandtestCard_AutocompleteBillingAddress_flowController_endpoint, replacecontinueButton.tap()withcontinueButton.waitForExistenceAndTap()and increase theconfirmButtontap timeout from the default 4 s to 10 s.Motivation
Both tests were intermittently failing at
successText.waitForExistence(timeout: 10.0). The root cause is a race condition:continueButton.tap()fires without waiting for the button to be hittable, and the subsequentconfirmButton.waitForExistenceAndTap()(default 4-second timeout) sometimes expires before the FlowController sheet finishes its dismiss animation and async work. UsingwaitForExistenceAndTap()oncontinueButtonand a 10-second timeout onconfirmButtongives each step enough time to complete reliably.Testing
Ran locally 50x
Changelog
N/A