Deflake testRefreshEndpointUsingCashAppPay 🪿✨ - #6862
Open
joyceqin-stripe wants to merge 4 commits into
Open
Deflake testRefreshEndpointUsingCashAppPay 🪿✨#6862joyceqin-stripe wants to merge 4 commits into
joyceqin-stripe wants to merge 4 commits into
Conversation
…rBar The TopBrowserBar can contain multiple elements labeled 'Close', causing the test to fail with 'Multiple matching elements found'. Using firstMatch ensures we tap the first (outermost) Close button unambiguously. Committed-By-Agent: goose
joyceqin-stripe
changed the title
joyceqin-stripe
marked this pull request as ready for review
August 7, 2026 15:52
joyceqin-stripe
enabled auto-merge (squash)
August 7, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minion run
Summary
Changed from waitForExistenceAndTap to tap because waitForExistenceAndTap didn't fully scroll to tap "Cash App", while just tap did. We also were already guaranteed its existence in the guard, so I think that's safe
Add
.firstMatchwhen querying the "Close" button insideTopBrowserBarintestRefreshEndpointUsingCashAppPay.Motivation
The XCUI query
app.otherElements["TopBrowserBar"].buttons["Close"]was matching two elements — oneButtondirectly insideTopBrowserBarand a second nestedButtonwithin anotherButton— causing the test to fail intermittently with:Using
.firstMatchresolves the ambiguity by always selecting the outermost "Close" button.Testing
Ran locally 50x
Changelog
N/A