SAE — Normalize Checkout shipping defaults - #6865
Open
gbirch-stripe wants to merge 4 commits into
Open
Conversation
gbirch-stripe
requested review from
porter-stripe and
wooj-stripe
and removed request for
a team
August 6, 2026 21:45
gbirch-stripe
force-pushed
the
gbirch/normalize-checkout-shipping-defaults
branch
from
August 6, 2026 22:10
50a6d0c to
a906bee
Compare
gbirch-stripe
force-pushed
the
gbirch/initialize-sae
branch
from
August 6, 2026 22:13
2c13a93 to
f8c712a
Compare
gbirch-stripe
force-pushed
the
gbirch/normalize-checkout-shipping-defaults
branch
from
August 6, 2026 22:13
a906bee to
eefdbff
Compare
gbirch-stripe
force-pushed
the
gbirch/normalize-checkout-shipping-defaults
branch
from
August 6, 2026 23:00
eefdbff to
e3c8621
Compare
| XCTAssertNil(checkout.session.shippingAddress) | ||
| } | ||
|
|
||
| func testInitDoesNotApplyDisallowedShippingDefault() async throws { |
Collaborator
There was a problem hiding this comment.
Is this a duplicate pretty much of testInitIgnoresShippingDefaultsWithDisallowedCountry? How does it differ?
Collaborator
Author
There was a problem hiding this comment.
Good point — now that we have handling + testing of this case via the Checkout initialization we don't need to test it on the SAE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
added unit tests