Move request telemetry to LiveStripeResponseGetter #1725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves responsibility for calculating queuing/calculating telemetry payloads and setting the
X-Stripe-Client-Telemetry
header fromHTTPClient
toLiveStripeResponseGetter
.Details
There are public
requestWithTelemetry
methods on HTTPClient that I changed to not trigger any (additional) telemetry anymore. It's a significant behavior change for a hypothetical user calling these methods directly, but I don't consider this a supported use.Motivation
HTTPClient should be responsible for sending already-calculated HTTP requests, it shouldn't be responsible for calculating what to put in the HTTP request itself. See discussion at https://github.com/stripe/stripe-java/pull/1721/files#r1454137531
Test strategy
Pretty good existing end-to-end telemetry test:
stripe-java/src/test/java/com/stripe/functional/TelemetryTest.java
Line 25 in c044fab