Beta: Stripe.rawRequest -> StripeClient.rawRequest #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
requested review from
a team and
pakrym-stripe
and removed request for
a team
richardm-stripe
commented
Jan 17, 2024
pakrym-stripe
requested changes
Jan 17, 2024
pakrym-stripe
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR copies
Stripe.rawRequesttoStripeClient.rawRequestand deprecates the former. The only difference is thatStripeClient.rawRequestis an instance method and usesthis.getStripeResponseGetter()vs. the global responseGetter.It also copies
Stripe.deserializetoStripeClient.deserialize.Motivation
I figured I would do this in advance of adding
usageto.rawRequest.