Open
Conversation
tonyxiao
approved these changes
Apr 2, 2026
Collaborator
tonyxiao
left a comment
There was a problem hiding this comment.
Looks good — solid E2E test infrastructure. Two minor nits:
-
sslConfigFromConnectionString.ts:43— Now thatpreferis handled alongsiderequire, add a comment explaining whyrejectUnauthorized: falseis correct:In Postgres's SSL hierarchy, neither
prefernorrequireverify the server certificate — they only guarantee encryption. Node'spgcan't do the "try TLS, fall back to plaintext" dance thatpreferimplies, so both collapse to: encrypted connection, no certificate verification. -
sslConfigFromConnectionString.ts:57— The error message still listsdisable, require, verify-ca, or verify-fullbut should now includeprefersince it's a supported value.
Neither is blocking. 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an end-to-end CI test that exercises the full supabase
install → backfill sync → verify flow against a real Supabase project
Each CI run spawns an ephemeral Supabase project via the Management API and tears
it down on completion (no shared state, no race conditions between branches)
Safety cap: if 8+ github-ci-spawned-* projects already exist,
the test fails fast to prevent runaway resource usage
Fixes sslmode=prefer handling and bundled OpenAPI spec fallback for Deno edge runtime
Makes backfill_concurrency configurable via CLI (--backfill-concurrency)
Sandbox
(Outside this PR) Stripe sandbox is seeded with the fixed amount of data that we check against.
Object | count
charges | 1110
checkout_sessions | 555
coupons | 555
customers | 555
disputes | 555
invoices | 1110
payment_intents | 1942
plans | 833
prices | 1110
products | 555
refunds | 555
setup_intents | 555
subscription_schedules | 555
subscriptions | 555