test(service): share one Temporal dev server across test files#236
Open
test(service): share one Temporal dev server across test files#236
Conversation
TestWorkflowEnvironment.createLocal() spawns a real Temporal dev server process. With Vitest's default file parallelism, workflow.test.ts and app.test.ts both called createLocal() concurrently, causing occasional "connection reset by peer" startup races on CI. Fix: start one shared dev server in vitest.global-setup.ts (Vitest globalSetup hook) and provide its address via Vitest's provide/inject API. Each test file connects with createFromExistingServer(), which only opens client connections — teardown() on these envs closes connections but does not kill the server. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
Committed-By-Agent: claude
tonyxiao
force-pushed
the
temporal-test-server-sharing
branch
from
869cf3a to
0797def
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestWorkflowEnvironment.createLocal()spawns a real Temporal CLI dev server process. With Vitest's default file parallelism,workflow.test.tsandapp.test.tsboth calledcreateLocal()concurrently, causing occasional "connection reset by peer" startup races on CI.vitest.global-setup.ts(VitestglobalSetuphook) and expose its address via Vitest'sprovide/injectAPI.createFromExistingServer({ address })instead ofcreateLocal().teardown()on these envs only closes connections — it does not kill the shared server.vitest.d.tsto declare theProvidedContexttype fortemporalTestServerAddress.Test plan
pnpm vitest runinapps/servicepasses all 14 tests (1 skip unchanged)localhost:XXXXXline at startup)pnpm format:check && pnpm lint && pnpm buildall clean🤖 Generated with Claude Code