Rename rebar3 CLI and module to rebar#15
Conversation
GwendalLaurent
left a comment
GwendalLaurent
left a comment
There was a problem hiding this comment.
You forgot to add a SPDX header to the files you modified. Some of them already have it because we modified them in previous PRs but not all of them.
I asked Codex if anything was missing and it told me the following:
- The Dockerfile still relies on the name
rebar3 - The bootstrap script still mentions rebar3:
- Line 65, 72, 73: it calls
rebar3:run/1 - Line 106: It uses the config file
config/rebar3 - Line 193 the function is called
bootstrap_rebar3 - Comments in the file still mention "rebar3"
- Line 65, 72, 73: it calls
- rebar.config.sample still uses "rebar3" in the comments and in the config values
- vendor_hex_core.sh still uses
rebar3 as dev compile - .gitignore still has the old rebar3 files (can keep these entries) but not the new ones. e.g. it has
rebar3.ps1but notrebar.ps1
We should also update the migration guide. One change we should add for this PR is the name change of course but maybe there are other things to mention like changes in the configuration files (renaming rebar3 entries to rebar, ...)
| long => "-aliases", | ||
| type => string, | ||
| help => "Comma separated list of OS level aliases on which rebar3 completion will be triggered (e.g. \"rebar\" or \"r3\")."}, | ||
| help => "Comma separated list of OS level aliases on which rebar completion will be triggered (e.g. \"r3\")."}, |
There was a problem hiding this comment.
There is still "rebar3" in the path
There was a problem hiding this comment.
There is still "rebar3" in the path
There was a problem hiding this comment.
There is still "rebar3" in the path
There was a problem hiding this comment.
There is still "rebar3" in the path
There was a problem hiding this comment.
Are we keeping the name "r3" in the name of the file ?
There was a problem hiding this comment.
I renamed r3 to rb. I thought using just r as a shell command wasn't a great idea, since it could conflict with the R programming language
There was a problem hiding this comment.
The filename rebar.1 does not make sense. This seems to be the manpage for version 3.1. We should figure out if we can simply delete it.
I think they are all fixed now :) |
|
@maehjam please take a look at the current state of the code and ignore the latest commit, I just wanted to make sure it builds in windows without errors. The broken windows CI is fixed on @Gwendal PR I had to run the bootstrap and vendor scripts, which means that some paths from my local machine where added to the generated files... I will like to change the asdf Erlang installation path, I will work on that tomorrow. |
| NewCache; | ||
| {ListOfDeps, NewCache} -> | ||
| lists:foldl( | ||
| fun(File, CurrentCache) -> |
There was a problem hiding this comment.
formatting change, not bad, but not related to renaming, may confuse if inspected with git blame
|
|
||
| dedupe(L) -> dedupe(L, sets:new()). | ||
|
|
||
| dedupe([], _) -> |
| [] -> | ||
| not_found | ||
| end; | ||
| erlang:error(?RLX_ERROR({strip_release, Reason})) | ||
| after | ||
| %% revert file permissions after strip. | ||
| [ file:change_mode(File, OrigMode) |
There was a problem hiding this comment.
formatting edits in this file too
4 participants
Renames the
rebar3command-line tool and its main Erlang module torebar.What changed
rebar3.erl→rebar.erl, all call sites updated./rebar~/.config/rebar3→~/.config/rebar,~/.cache/rebar3→~/.cache/rebar,.rebar3→.rebarrebar3.crashdump→rebar.crashdumpfunctions
_rebar3→_rebarproject_typeatom:rebar3→rebarlocal install/local upgrade: env varsREBAR3_VSN→REBAR_VSN,REBAR3_ERL_ARGS→REBAR_ERL_ARGSbuild_toolslabelrebar3→rebar./rebar3→./rebar,.\rebar3.ps1→.\rebar.ps1rebar3.1→rebar.1README.md,CONTRIBUTING.md,ISSUE_TEMPLATE.md, inline comments and help stringsNote, the following was intentionally kept as-is
rebar3.orgURLs and all external linkserlang/rebar3GitHub repository referencesSPDX-FileCopyrightTextcopyright headersrebar3_tests)README.mdsection header anchors (#what-is-rebar3, etc.)