Fix race between publisher connected / subscriber waiting.#1263
Open
fancycode wants to merge 1 commit into
Open
Fix race between publisher connected / subscriber waiting.#1263fancycode wants to merge 1 commit into
fancycode wants to merge 1 commit into
Codecov / codecov/project
succeeded
Jun 16, 2026 in 0s
62.89% (+0.08%) compared to d82f7f2
View this Pull Request on Codecov
62.89% (+0.08%) compared to d82f7f2
Details
Codecov Report
❌ Patch coverage is 88.29787% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.89%. Comparing base (d82f7f2) to head (c21c347).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| sfu/janus/test/janus.go | 0.00% | 8 Missing |
| async/notifier.go | 97.36% | 1 Missing and 1 partial |
| sfu/janus/remote_publisher.go | 50.00% | 1 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## master #1263 +/- ##
==========================================
+ Coverage 62.80% 62.89% +0.08%
==========================================
Files 129 129
Lines 18810 18861 +51
==========================================
+ Hits 11814 11863 +49
Misses 5897 5897
- Partials 1099 1101 +2 | Components | Coverage Δ | |
|---|---|---|
| root | ∅ <ø> (∅) |
|
| api | 81.70% <ø> (ø) |
|
| async | 87.47% <97.36%> (+0.70%) |
⬆️ |
| client | 70.38% <ø> (ø) |
|
| cmd/client | 6.34% <ø> (ø) |
|
| cmd/proxy | 60.59% <ø> (ø) |
|
| cmd/server | 0.00% <ø> (ø) |
|
| config | 82.14% <ø> (ø) |
|
| container | 93.79% <ø> (ø) |
|
| dns | 90.82% <ø> (ø) |
|
| etcd | 81.96% <ø> (ø) |
|
| geoip | 68.09% <ø> (ø) |
|
| grpc | 75.56% <ø> (ø) |
|
| internal | 96.12% <ø> (ø) |
|
| log | 94.44% <ø> (ø) |
|
| metrics | 90.00% <ø> (ø) |
|
| mock | ∅ <ø> (∅) |
|
| nats | 73.55% <ø> (ø) |
|
| pool | 81.91% <ø> (ø) |
|
| proxy | 81.35% <ø> (ø) |
|
| security | 77.50% <ø> (-1.25%) |
⬇️ |
| server | 72.17% <ø> (+0.03%) |
⬆️ |
| session | 78.57% <ø> (ø) |
|
| sfu | 43.71% <50.00%> (+0.05%) |
⬆️ |
| talk | 69.27% <ø> (+0.28%) |
⬆️ |
| test | 86.04% <ø> (ø) |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| sfu/janus/janus.go | 57.66% <100.00%> (+0.18%) |
⬆️ |
| sfu/janus/publisher.go | 45.42% <100.00%> (+0.20%) |
⬆️ |
| sfu/janus/remote_publisher.go | 34.61% <50.00%> (+0.84%) |
⬆️ |
| async/notifier.go | 97.89% <97.36%> (-2.11%) |
⬇️ |
| sfu/janus/test/janus.go | 0.00% <0.00%> (ø) |
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Loading