Add support for auto install of Firefox screen sharing extension #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static/js/services/screensharing.js
Outdated
Contributor
There was a problem hiding this comment.
Why is this a function? I also do not like this globalNotify thing much. Why do you need these events?
Contributor
Author
There was a problem hiding this comment.
I need these events to notify the plugin when to insert the domain and when to remove it from Firefox.
Contributor
Author
There was a problem hiding this comment.
I changed globalNotify to simply use a dictionary.
… choose the screen you share after you install extension.
…ring starts and stops.
theurere
force-pushed
the
add-firefoxextension-service
branch
from
4af02f5 to
de5bac2
Compare
…er to share screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.