Enable run without mpi4py #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

max-models merged 13 commits into devel-tiny from no-mpi

Oct 20, 2025

Member

spossann commented Oct 16, 2025

moved mpi.py from Struphy to ddm/mpi.py


          add file ddm/mpi.py for MockMPI and MPIWrapper (previously in Struphy…

bfb9bc0

…, now moved here)

spossann requested a review from max-models

October 16, 2025 14:27

spossann added 2 commits

October 16, 2025 16:58


          fix assertions in cart.py

2f39539


          fix mpi4py imports everywhere

73ece1c

Member

max-models commented Oct 16, 2025

Should we move mpi4py to an optional dependency so we can run the tests without installing MPI?


          make mpi4py an optional dependency; run tests without mpi too

04e3980

Member Author

spossann commented Oct 17, 2025

Should we move mpi4py to an optional dependency so we can run the tests without installing MPI?

Done in 04e3980

spossann added 4 commits

October 17, 2025 07:44


          add forgotton change

1eb0297


          change version to 2.5.0 for last release still on GitLab

af5279a


          install Struphy from branch 467-no-mpi; perform Struphy unit tests on…

e81aee4

… 1 and 2 processes


          checkout correct Struphy branch 467-no-mpi

c423b57

max-models reviewed

View reviewed changes

.github/workflows/testing.yml Outdated Show resolved Hide resolved

max-models reviewed

View reviewed changes

psydac/ddm/tests/test_cart_1d.py Outdated Show resolved Hide resolved

max-models reviewed

View reviewed changes

psydac/ddm/tests/test_cart_3d.py Outdated

    
                  if TYPE_CHECKING:

                      from mpi4py import MPI

                  else:

                      from psydac.ddm.mpi import mpi as MPI

Member

max-models Oct 17, 2025

Same comment as https://github.com/max-models/psydac-for-struphy/pull/45/files#r2438946515

max-models reviewed

View reviewed changes

psydac/ddm/tests/test_multicart_2d.py Outdated Show resolved Hide resolved

max-models reviewed

View reviewed changes

psydac/ddm/blocking_data_exchanger.py Outdated Show resolved Hide resolved

max-models reviewed

View reviewed changes

psydac/ddm/tests/test_cart_2d.py Outdated Show resolved Hide resolved

max-models reviewed

View reviewed changes

psydac/ddm/cart.py Outdated Show resolved Hide resolved

max-models reviewed

View reviewed changes

psydac/ddm/interface_data_exchanger.py Outdated Show resolved Hide resolved

max-models reviewed

View reviewed changes

psydac/ddm/mpi.py Outdated Show resolved Hide resolved

max-models reviewed

View reviewed changes

psydac/ddm/mpi.py Outdated Show resolved Hide resolved

Member

max-models commented Oct 17, 2025

Nice job! It's pretty cool that so few changes in the code were needed! Maybe this could be a suggestion for the upstream psydac repo to implement too.

spossann added 3 commits

October 17, 2025 13:37


          correct TODO to devel


          remove the unneccessary if TYPE_CHECKING thing from all files, except…

34f223f

… mpi.py


          set mpi_enabled to True if mpi4py is installed, TODO: check if it run…

8a73263

…s under mpirun

spossann self-assigned this

spossann added 2 commits

October 20, 2025 08:48


          test with updated struphy branch

6f632dc


          test with updated struphy branch

9a4ea9a

spossann marked this pull request as ready for review

October 20, 2025 08:55

Member

max-models commented Oct 20, 2025

Looks good now! I will merge it.

max-models merged commit 6d4f44e into devel-tiny

18 checks passed

max-models deleted the no-mpi branch

October 20, 2025 13:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet