Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve build, restore and test #2845

Merged
merged 19 commits into from
Mar 1, 2024
Merged

fix: Improve build, restore and test #2845

merged 19 commits into from
Mar 1, 2024

Conversation

dupdob
Copy link
Member

@dupdob dupdob commented Feb 14, 2024

Misc fixes:

  1. Drop use of now obsolete VsTest async APIs (but keep some async behaviour to deal with VsTest freezes)
  2. Ensure project analysis is done in the same way between Project and Solution mode
  3. Improve readability of the log dump of Buildalyzer results
  4. Log Stryker version number at start
  5. Restore packages and retry build when it fails
  6. Respect MaxConcurrency settings when doing project analysis
  7. Correct logic when failing to get MsBuild version. Not sure if this can happen, but existing logic logged an error and tried to keep on while using the error message as a version number.
  8. Enlarge search perimeter for nuget.exe (from drive root) when not found in path
  9. Log an error when failing to restore packages
  10. Adjust VsTest settings to prevent freezes with latest versions (force using an external test host)
  11. Add a logging workflow for DataCollector and log an error when failing to retrieve MutantControl info
  12. No longer tests the first project in a solution against all test projects (reduce needless run time)

other changes:
ProcessExecutor.Start method now longer alters the path used for execution, some uses have been adjusted accordingly. Note that this may fix some surprising bugs in non standard configuration.
Note: this PR is in draft mode as I try to fix some new VsTest freeze scenarios whit small test projects

@dupdob dupdob marked this pull request as ready for review February 22, 2024 16:41
@rouke-broersma rouke-broersma changed the title Fixes related to VsTest and logging fix: Improve build, restore and test Mar 1, 2024
@rouke-broersma rouke-broersma enabled auto-merge (squash) March 1, 2024 09:27
Copy link

sonarqubecloud bot commented Mar 1, 2024

@rouke-broersma rouke-broersma merged commit a14b64b into master Mar 1, 2024
9 checks passed
@rouke-broersma rouke-broersma deleted the fixes_022024 branch March 1, 2024 09:47
@dupdob
Copy link
Member Author

dupdob commented Mar 1, 2024

🙏

@rouke-broersma
Copy link
Member

🙏

Thanks for the improvements 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants