support sampling with and without replacement#58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the library sampling logic used in the bootstrap procedure to ensure statistical correctness and improve flexibility.
Key changes
Add support for sampling with replacement (bootstrap)
replace_sampling == true, library indices are now sampled with replacement using a uniform distributionRetain subsampling (without replacement) as an alternative mode
replace_sampling == false, the existing shuffle-based subsampling strategy is preservedDeterministic behavior when
boot == 1Lindices without randomizationMotivation
Previously, the implementation only supported sampling without replacement, which corresponds to subsampling rather than true bootstrap. This can underestimate variability and lead to biased confidence intervals, especially for nonlinear statistics such as pattern causality measures.
By introducing proper bootstrap sampling:
Notes