Skip to content

Class feedback form #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 89 commits into from
Jun 17, 2021
Merged

Class feedback form #153

merged 89 commits into from
Jun 17, 2021

Conversation

andreicmirciu
Copy link
Member

@andreicmirciu andreicmirciu commented Mar 27, 2021

Allow users to provide feedback on a class, as it happens on Moodle platform.

@andreicmirciu andreicmirciu marked this pull request as draft March 27, 2021 22:03
@acs-upb-mobile-bot
Copy link
Member

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #153 (9b6f032) into master (0337750) will decrease coverage by 2.74%.
The diff coverage is 17.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   69.56%   66.81%   -2.75%     
==========================================
  Files          80       83       +3     
  Lines        6348     6699     +351     
==========================================
+ Hits         4416     4476      +60     
- Misses       1932     2223     +291     
Impacted Files Coverage Δ
lib/generated/l10n.dart 57.58% <0.00%> (-6.46%) ⬇️
lib/pages/class_feedback/class_feedback_view.dart 0.00% <0.00%> (ø)
lib/pages/class_feedback/form_field.dart 0.00% <0.00%> (ø)
lib/widgets/radio_emoji.dart 0.00% <0.00%> (ø)
lib/pages/classes/view/class_view.dart 62.50% <28.57%> (-1.74%) ⬇️
lib/generated/intl/messages_en.dart 96.79% <100.00%> (+0.36%) ⬆️
lib/generated/intl/messages_ro.dart 96.08% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0337750...9b6f032. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

Merging #153 (741db0a) into master (5471d74) will increase coverage by 0.41%.
The diff coverage is 75.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   68.43%   68.84%   +0.41%     
==========================================
  Files          84       95      +11     
  Lines        6634     7110     +476     
==========================================
+ Hits         4540     4895     +355     
- Misses       2094     2215     +121     
Impacted Files Coverage Δ
lib/main.dart 47.82% <0.00%> (-2.18%) ⬇️
...ages/class_feedback/service/feedback_provider.dart 0.00% <0.00%> (ø)
lib/pages/classes/service/class_provider.dart 0.80% <0.00%> (-0.03%) ⬇️
...ib/pages/class_feedback/service/remote_config.dart 20.00% <20.00%> (ø)
lib/widgets/selectable.dart 67.39% <42.85%> (+2.17%) ⬆️
lib/generated/l10n.dart 64.19% <67.56%> (+0.10%) ⬆️
lib/widgets/radio_emoji.dart 83.33% <83.33%> (ø)
lib/pages/people/view/people_page.dart 83.17% <92.30%> (+5.23%) ⬆️
lib/pages/classes/view/class_view.dart 67.51% <94.44%> (+3.23%) ⬆️
lib/widgets/feedback_question.dart 96.66% <96.66%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5471d74...741db0a. Read the comment docs.

# Conflicts:
#	lib/generated/intl/messages_en.dart
#	lib/generated/intl/messages_ro.dart
#	lib/generated/l10n.dart
#	lib/l10n/intl_en.arb
#	lib/l10n/intl_ro.arb
# Conflicts:
#	lib/pages/classes/view/class_view.dart
# Conflicts:
#	lib/generated/intl/messages_en.dart
#	lib/generated/intl/messages_ro.dart
#	lib/generated/l10n.dart
#	lib/l10n/intl_en.arb
#	lib/l10n/intl_ro.arb
@andreicmirciu andreicmirciu merged commit a07eedd into master Jun 17, 2021
@IoanaAlexandru IoanaAlexandru deleted the andreicmirciu/feedback branch June 17, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants