Filter by information source #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. In testing on compatibility with the quarry.
# Conflicts: # pubspec.lock
…ion. In testing on compatibility with the quarry.
# Conflicts: # pubspec.lock
# Conflicts: # lib/authentication/service/auth_provider.dart # lib/pages/home/home_page.dart # pubspec.lock
# Conflicts: # lib/authentication/service/auth_provider.dart # lib/pages/faq/service/question_provider.dart # lib/pages/home/home_page.dart # lib/pages/people/service/person_provider.dart # lib/pages/portal/service/website_provider.dart # pubspec.lock
# Conflicts: # lib/pages/people/model/person.dart
AdrianMargineanu
commented
May 4, 2022
I have solved the intl file generation |
IoanaAlexandru
requested changes
May 6, 2022
| @@ -720,6 +728,15 @@ Future<void> main() async { | |||
| }); | |||
|
|
|||
| group('Home', () { | |||
| setUp(() { | |||
| when(mockAuthProvider.currentUser).thenAnswer((_) => Future.value(User( | |||
There was a problem hiding this comment.
Add a test verifying that if the user sources are null, the sources page pops up?
There was a problem hiding this comment.
@AdrianMargineanu can help with this?
| @@ -436,8 +448,11 @@ void main() { | |||
|
|
|||
| group('Feedback form', () { | |||
There was a problem hiding this comment.
Add a test that you can open the sources page.
There was a problem hiding this comment.
@AdrianMargineanu can help with this?
IoanaAlexandru
requested changes
May 8, 2022
There was a problem hiding this comment.
PR looks pretty good now, please fix the tests and prepare for release (check the "Deployment" section here for some instructions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to select the information sources they would like to use (official or not).