-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add ability to register private blocks, sets and presets #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
robdekort
wants to merge
95
commits into
main
Choose a base branch
from
feature/refactor-install-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/studio1902/statamic-peak-commands into feature/refactor-install-commands
…m/studio1902/statamic-peak-commands into feature/refactor-install-commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the ability to register custom private blocks, sets, and presets by refactoring the commands addon.
- Added a new changelog section for version v8.17.0 (Unreleased) outlining new features, improvements, and fixes
- Updated the changelog entries to reference the new registration functionality
Files not reviewed (8)
- composer.json: Language not supported
- config/statamic-peak-commands.php: Language not supported
- phpunit.xml: Language not supported
- resources/blocks/call_to_action/config.php: Language not supported
- resources/blocks/cards/config.php: Language not supported
- resources/blocks/collection/config.php: Language not supported
- resources/blocks/columns/config.php: Language not supported
- resources/blocks/divider/config.php: Language not supported
Comments suppressed due to low confidence (1)
CHANGELOG.md:6
- [nitpick] Consider rephrasing for clarity. For example, 'Register your own private blocks, sets, and presets for installation.' may better reflect the PR's intent.
- The ability to load in your own private blocks, sets and presets to install. #28 by @marcorieser
# Conflicts: # resources/presets/faq/resources/views/page_builder/_faq.antlers.html # resources/stubs/presets/business_hours/business_hours_snippet.antlers.html.stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR by @marcorieser and me is a refactor of the commands addon that adds the ability to register custom private locations for
blocks
,sets
andpresets
.To register custom content:
blocks
,sets
orpresets
.config.php
using the following pattern.