Skip to content

Conversation

@Gibson431
Copy link
Contributor

This allows the process function to handle all the different possible visit types without excess compute.

@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 84.72222% with 44 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
core/src/filesystem/media/format/rar.rs 62.00% 19 Missing ⚠️
core/src/filesystem/media/format/pdf.rs 61.53% 10 Missing ⚠️
core/src/filesystem/media/format/zip.rs 84.48% 9 Missing ⚠️
core/src/filesystem/media/format/epub.rs 97.69% 3 Missing ⚠️
core/src/filesystem/media/process.rs 33.33% 2 Missing ⚠️
core/src/filesystem/media/builder.rs 95.23% 1 Missing ⚠️
Files with missing lines Coverage Δ
core/src/filesystem/media/builder.rs 73.77% <95.23%> (+4.26%) ⬆️
core/src/filesystem/media/process.rs 29.09% <33.33%> (-3.33%) ⬇️
core/src/filesystem/media/format/epub.rs 81.74% <97.69%> (+43.50%) ⬆️
core/src/filesystem/media/format/zip.rs 83.91% <84.48%> (+8.20%) ⬆️
core/src/filesystem/media/format/pdf.rs 23.91% <61.53%> (-5.08%) ⬇️
core/src/filesystem/media/format/rar.rs 55.45% <62.00%> (-6.09%) ⬇️

... and 60 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a look during lunch and think you're headed in the right direction here. I know you mentioned not being fully done, so feel free to give me a nudge when you would like me to take another look.

Also, thanks for adding additional tests 🙂

@Gibson431 Gibson431 marked this pull request as ready for review March 26, 2025 11:05
@Gibson431
Copy link
Contributor Author

I noticed a lot of the functioned that have been changed aren't actually used anywhere. This does reduce the number of mime_type check duplication. There is still some duplication though I don't know how they could / should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants