-
-
Notifications
You must be signed in to change notification settings - Fork 89
♻️ Make FileProcessor::process handle all visit types
#627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: experimental
Are you sure you want to change the base?
Conversation
aaronleopold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this a look during lunch and think you're headed in the right direction here. I know you mentioned not being fully done, so feel free to give me a nudge when you would like me to take another look.
Also, thanks for adding additional tests 🙂
|
I noticed a lot of the functioned that have been changed aren't actually used anywhere. This does reduce the number of mime_type check duplication. There is still some duplication though I don't know how they could / should be removed. |
84f9c8a to
e114b9d
Compare
e114b9d to
681b131
Compare
This allows the process function to handle all the different possible visit types without excess compute.