docs(examples): add vm-deploy bundle, fix creds key, ignore generated dir#65
Merged
Merged
Conversation
… dir - Add examples/cluster/vm-deploy/ (Secret tmpl + ProviderConfig + VirtualMachine + README): a sanitized, end-to-end cluster-scoped deploy example (opaque MOIDs only, no env-identifying data). - Fix credentials Secret templates to use key "user" (NOT "username"); internal/clients/vsphere.go reads creds["user"], and a wrong key sends an empty user, making vCenter reject the login with a misleading "incorrect user name or password". - Remove examples/cluster/virtualmachine/movie-scripts2.yaml (filename/resource-name mismatch + env-specific scratch VM, redundant with virtualmachine.yaml). - gitignore /examples-generated/ (wiped + regenerated by go generate). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
examples/cluster/vm-deploy/— a sanitized, end-to-end cluster-scoped deploy example (Secret template → ProviderConfig → VirtualMachine + README). Uses only opaque MOIDs/UUIDs; no environment-identifying data (lab names, hostnames, IPs, usernames).cluster+namespacedproviderconfig) to use keyuser, notusername.internal/clients/vsphere.goreadscreds["user"]; the wrong key passed an empty user, so vCenter rejected logins with the misleadingServerFaultCode: Cannot complete login due to an incorrect user name or password.examples/cluster/virtualmachine/movie-scripts2.yaml— filename/resource-name mismatch (movie-scripts2vsmovie-scripts5), env-specific scratch VM, redundant withvirtualmachine.yaml./examples-generated/— it is wiped + regenerated bygo generate(apis/generate.go), so it should never be hand-edited or tracked.Why
Anyone copying the shipped example Secret hit a dead-end auth failure because of the
usernamekey. This was the exact root cause of a real deploy getting stuckSYNCED=Falsefor hours.🤖 Generated with Claude Code