Update function substitution regex to work better under Rails #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some JS formatter functions, the regex in
renderer#substitute_function_objectwas not parsing correctly when run under Rails and was returning empty function declarations in the rendered output. I worked with AI for longer than I care to admit to try and create a failing test case to match what I was seeing in Rails. The same JSON getting passed to#substitute_function_objectwas working in the standalone gem test cases, but not when the gem was running within the Rails application. I'm guessing it has something to do with how JSON conversion is patched within Rails and how strings are being escaped.For example, the following JS formatter function:
results in the following rendered content before this change:
after this change, it renders the expected content: