Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions __tests__/index.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -42,30 +42,38 @@ describe('flags warnings with invalid scss', () => {
assert.equal(result.errored, true);
});

it('flags one warning', () => {
assert.equal(result.results[0].warnings.length, 1);
it('flags two warnings', () => {
assert.equal(result.results[0].warnings.length, 2);
});

it('correct warning text', () => {
it('correct warning texts', () => {
assert.equal(
result.results[0].warnings[0].text,
'Expected @if not statement rather than @if statement == null (scss/at-if-no-null)',
);
assert.equal(
result.results[0].warnings[1].text,
'Expected the color.channel function to be used (scss/function-color-channel)',
);
});

it('correct rule flagged', () => {
it('correct rules flagged', () => {
assert.equal(result.results[0].warnings[0].rule, 'scss/at-if-no-null');
assert.equal(result.results[0].warnings[1].rule, 'scss/function-color-channel');
});

it('correct severity flagged', () => {
assert.equal(result.results[0].warnings[0].severity, 'error');
assert.equal(result.results[0].warnings[1].severity, 'error');
});

it('correct line number', () => {
it('correct line numbers', () => {
assert.equal(result.results[0].warnings[0].line, 1);
assert.equal(result.results[0].warnings[1].line, 4);
});

it('correct column number', () => {
it('correct column numbers', () => {
assert.equal(result.results[0].warnings[0].column, 5);
assert.equal(result.results[0].warnings[1].column, 14);
});
});
4 changes: 4 additions & 0 deletions __tests__/invalid.scss
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
@if $x == null { color: red; }

p {
opacity: color.alpha(rgb(210, 225, 221, 0.4));
}
4 changes: 4 additions & 0 deletions __tests__/valid.scss
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,7 @@ $global-variable: first global value;
from { opacity: 0%; }
to { opacity: 100%; }
}

p {
opacity: color.channel(rgb(210, 225, 221, 0.4), "alpha");
}
8 changes: 2 additions & 6 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,7 @@ module.exports = {
'function-no-unknown': null,
'media-feature-name-value-no-unknown': null,
'media-query-no-invalid': null,
'no-invalid-position-at-import-rule': [
true,
{
ignoreAtRules: ['use', 'forward'],
},
],
'no-invalid-position-at-import-rule': [true, { ignoreAtRules: ['use', 'forward'] }],
'string-no-newline': true,
'unit-no-unknown': true,
'scss/at-extend-no-missing-placeholder': true,
Expand All @@ -33,6 +28,7 @@ module.exports = {
'scss/comment-no-empty': true,
'scss/declaration-nested-properties-no-divided-groups': true,
'scss/dollar-variable-no-missing-interpolation': true,
'scss/function-color-channel': true,
'scss/function-quote-no-quoted-strings-inside': true,
'scss/function-unquote-no-unquoted-strings-inside': true,
'scss/load-no-partial-leading-underscore': true,
Expand Down