-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-sync CI status for each package #24
Conversation
@romainmenke Thank you for the great improvement! Overall, I love this change. 😄
I have the same opinion on this. 😅 Instead, I feel that the |
Thanks. I love the |
Co-authored-by: Masafumi Koba <[email protected]>
Co-authored-by: Masafumi Koba <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! This is a great achievement. Feel free to merge. 😄 👍🏼
Once WordPress/gutenberg#64828 is merged, we will have to change the test command for |
The
|
Closes #22
See https://github.com/romainmenke/stylelint-ecosystem-tester/tree/main?tab=readme-ov-file#packages
I worked on a separate fork so that I could more easily test everything without causing noise here.
Let me know if you want me to also setup a branch here with the changes if that makes it easier to do code review.
What I like about this approach:
But there are also some things I don't like.
There are ±50 workflows named
latest
and another ±50 namednext
I don't like that the workflows UI on GitHub becomes much harder to navigate when there are so many workflows and when they all have the same name.
This is needed to get nice labels :
The
checks
do have nice names :Apparently GitHub sends a notification for each failing workflow.
Each time there is an issue it would ping the person who last altered the cron schedule. This is pretty random and noisy.
But maybe this is ok?
Our aim is to have this as green as possible.
Each time a package fails either we broke something in a Stylelint update, or the package author broke something. So the notification could be regarded as useful.
(I've already fixed
stylelint-use-nesting
)