Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show latest Stylelint version in README #26

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

README.md Outdated
@@ -10,7 +10,7 @@ To see test results, click the status badge for the relevant package in the list

<!-- START:PACKAGES -->

| Package | Latest Stylelint | Next Stylelint |
| Package | Latest Stylelint (16.7.0) | Next Stylelint |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe als use an npm badge here?
So that it is always up to date?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice idea! I'll update it to use badge 👍🏼

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a slight shift between the image and the text, but do you have any idea?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the label query option:

[![Latest Stylelint](https://img.shields.io/npm/v/stylelint.svg?label=Latest+Stylelint)](https://www.npmjs.com/package/stylelint)

How about this?

Latest Stylelint

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a slight shift between the image and the text, but do you have any idea?

image

Try adding align="middle".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All browsers support it and style="…" would be ignored by GitHub so you don't have much choice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we set align in Markdown?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<a href="https://www.npmjs.com/package/stylelint">Latest Stylelint</a> <img align="top" alt="Latest Stylelint" src="https://img.shields.io/npm/v/stylelint.svg" />

Latest Stylelint Latest Stylelint

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, using HTML tags in Markdown seems too much to me in this case.

@romainmenke Any thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown also seems ok to me :)
We can improve as we go along.

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ybiquitous ybiquitous merged commit da96d72 into main Jul 29, 2024
6 checks passed
@ybiquitous ybiquitous deleted the show-latest-stylelint-version-in-readme branch July 29, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants