Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable @shopify/stylelint-plugin #43

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Sep 8, 2024

Which issue, if any, is this issue related to?

See #39

Is there anything in the PR that needs further explanation?

Blocked on Shopify/web-configs#435

@romainmenke romainmenke changed the title enable @shopify/stylelint-plugin Enable @shopify/stylelint-plugin Sep 8, 2024
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this PR itself looks good! 👍🏼

Let's wait for your PR to the Shopify's plugin repo to be merged.

Base automatically changed from disable-failing-tests--resourceful-chamois-34ea5460c9 to main September 9, 2024 06:15
@romainmenke
Copy link
Member Author

All green 🎉

@romainmenke romainmenke merged commit 2a03673 into main Sep 9, 2024
8 checks passed
@romainmenke romainmenke deleted the enable-shopify--unassuming-avocet-cbb33e173a branch September 9, 2024 20:34
@ybiquitous
Copy link
Member

Great work! Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants