Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stylelint 16 to ci #633

Closed
wants to merge 4 commits into from
Closed

Add stylelint 16 to ci #633

wants to merge 4 commits into from

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Jan 25, 2025 •
edited
Loading

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

  • some rules no longer exists in Stylelint 16
    • indentation
    • color-hex-case
    • ...
  • formatting related rules no longer exist in Stylelint 16. So using Stylelint as the formatter "driver" is less useful.
  • jest can work correctly when using node 22 or later
  • jest snapshots have a different format now.

@romainmenke romainmenke changed the title Add stylelint 16 to ci affectionate discus fa948e685c Add stylelint 16 to ci Jan 25, 2025
@ota-meshi ota-meshi force-pushed the add-stylelint-16-to-ci--affectionate-discus-fa948e685c branch from 2eff10b to f210cbc Compare March 6, 2025 02:07
@ota-meshi ota-meshi mentioned this pull request Mar 6, 2025
Merged
@ybiquitous ybiquitous deleted the add-stylelint-16-to-ci--affectionate-discus-fa948e685c branch March 6, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romainmenke