-
Notifications
You must be signed in to change notification settings - Fork 866
[WIP] Preconditioning for multicomponent flows #2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Cristopher-Morales
wants to merge
53
commits into
develop
Choose a base branch
from
feature_preconditioning
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+582
−84
Open
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
ca9083e
solving for enthalpy
Cristopher-Morales 0487a68
fixing flux jacobian
Cristopher-Morales dd369bb
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 5076f9d
fix output error
Cristopher-Morales 09fe6f4
adding enthalpy diffusion
Cristopher-Morales 851b13f
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales f258308
moving enthalpy diffusion terms to CIncNSSolver.cpp
Cristopher-Morales 63a8f37
small fix
Cristopher-Morales cb1d3ef
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 30d0b88
cleaning and rewritting some functions
Cristopher-Morales dd22fcd
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 7f92730
axisymetric source term and corrected flux jacobian at the wall
Cristopher-Morales fdbb9b9
updating BC_ConjugateHeat_Interface for fluid mixture
Cristopher-Morales c0b10a6
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 911c996
Merge branch 'develop' into feature_preconditioning
2af10c3
activating muscl, consistent extrapolation for multicomponent
d0d0221
Merge branch 'develop' into feature_preconditioning
a1f526c
correct average enthalpy for multicomponent flows output
c469d32
Merge branch 'develop' into feature_preconditioning
ef2dc5f
changing boolean names
94bd0b0
up to date to develop
1c44044
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 912642b
adding brackets
Cristopher-Morales a6ce2d4
fixing warning
Cristopher-Morales e9d1e1f
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 127df29
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 211dda0
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 0655c99
adding standard reference temperature T0=298.15K as default value
Cristopher-Morales b8b45ef
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales aca6e19
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 5c656bb
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 3f45e1c
reformulating and cleaning
Cristopher-Morales b1fc9d4
cleaning flow_diffusion.hpp and .cpp
Cristopher-Morales b23913a
removing spaces
Cristopher-Morales 1961b08
fix description working variable
Cristopher-Morales 02e5eac
update parallel regresion test
Cristopher-Morales 810d2df
fix non-dimensionalization issue
Cristopher-Morales 70ae6ee
updating species Non-Dimensional test case
Cristopher-Morales e9d3f4c
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 165a9ad
fix parallel_regression.py
Cristopher-Morales eabaabf
updating regression test cases
Cristopher-Morales 96c6219
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales e1d873b
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales bbb76ae
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 52a1689
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 8d829b2
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 8a6b0f0
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 6a54f9f
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 761a3ac
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 31b6101
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales be00947
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales ca43883
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales f1ddb3c
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems inconsistent with the SetTDState_* functions.
Should this be SetTDState_h and then you use GetTemperature to get the temperature?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the pull request made by evert regarding preferential diffusion, he also used the same function for the flamelet solver. The only difference is that that function is in the CSpeciesFlameletSolver.cpp and I cannot access to that function when I set the primitives in SetPrimVar in CIncNSVariable.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point is again to keep an abstract interface.
Evert's function is a private function of a specific solver which is perfectly fine, and it uses the fluid model... If you need a similar function, move it somewhere higher up in the hierarchy to make it accessible. For example the scalar solver. Or even the fluid model but implemented in a way that keeps it useful for all fluids.