[WIP] Multizone adjoints for turbomachinery #2446

joshkellyjak · 2025-02-18T16:22:06Z

Proposed Changes

This is a cleaned up PR of the fixes needed for multizone adjoints for turbomachinery from the previous PR of @oleburghardt and I's work.

This hopefully is useable, so if you would like to test and report please feel free to contact me on Slack.

TODO:

Fix eddy viscosity tape issue in CNSSolver
Add turbomachinery objective functions + constraints
Include MZ testcase

Related Work

Now closed PR #2317

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

[ X ] I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

pcarruscag · 2025-02-20T08:51:45Z

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

+    AD::EndPreacc();
+
    /*--- Max is not differentiable, so we not register them for preacc. ---*/


What is the difference between ending the preaccumulation before or after?

pcarruscag · 2025-02-20T08:51:59Z

Common/src/CConfig.cpp

    }
+  } else if (Multizone_Problem && DiscreteAdjoint) {
+      SU2_MPI::Error(string("OUTPUT_WRT_FREQ cannot be specified for this solver "


Suggested change

SU2_MPI::Error(string("OUTPUT_WRT_FREQ cannot be specified for this solver "

SU2_MPI::Error("OUTPUT_WRT_FREQ cannot be specified for this solver "

pcarruscag · 2025-02-20T08:52:47Z

Common/src/CConfig.cpp

+                            "(writing of restart and sensitivity files not possible for multizone discrete adjoint during runtime yet).\n"
+                            "Please remove this option from the config file, output files will be written when solver finalizes.\n"), CURRENT_FUNCTION);


Hmmm I'm pretty sure it is possible

This is one for @oleburghardt

Yes and no, writing the files is fine, but the continuation of the multi-zone discrete adjoint solver is erratic. My guess is that some indices aren't cleared properly before re-recording the tape. (Writing adjoint solution variables to file only, without re-recording at all and without sensitivities, might give us some hints.)
The debug mode could eventually pin down where exactly things go wrong.

pcarruscag · 2025-02-20T08:55:35Z

SU2_CFD/src/solvers/CDiscAdjSolver.cpp

-    BPressure = config->GetPressureOut_BC();
-    Temperature = config->GetTotalTemperatureIn_BC();
-
    if (!reset){
      AD::RegisterInput(BPressure);
      AD::RegisterInput(Temperature);
    }

+    BPressure = config->GetPressureOut_BC();
+    Temperature = config->GetTotalTemperatureIn_BC();
+


Why are these wrong but not the others that follow the same pattern?

This threw a tagging error, and if I remember correctly it's because in the other sections the variables it accesses are directly used in the solver, whereas in the Giles implementation they are not, creating a mismatch in tags.

Can we fix it in a way that keeps a clear pattern for doing this type of thing?

I can give it a go

…ding of objective function calculation

…e_mz_turbomachinery_adjoint

SU2_CFD/src/iteration/CDiscAdjFluidIteration.cpp

SU2_CFD/src/iteration/CTurboIteration.cpp

SU2_CFD/src/solvers/CEulerSolver.cpp

… to run in quasi-MZ approach. (NEEDS CLEANING)

SU2_CFD/src/drivers/CDiscAdjMultizoneDriver.cpp

+  // /*--- Turbo Specific Post-Procesisng ---*/
+  // if (config_container[iZone]->GetBoolTurbomachinery()){
+  //   direct_iteration[iZone][INST_0]->Postprocess(output_container[iZone], integration_container, geometry_container, solver_container, numerics_container, config_container, surface_movement, grid_movement, FFDBox, iZone, INST_0);
+  // }


To fix the problem, we need to either remove the commented-out code entirely or reinstate it into the program. Since the code appears to be functional and related to "Turbo Specific Post-Processing," it is likely intended to be part of the program's functionality. Therefore, the best approach is to reinstate the code by uncommenting it. This ensures that the functionality is included and tested, and it eliminates the distraction of commented-out code.

The changes will be made in the DirectIteration method of the CDiscAdjMultizoneDriver class, specifically around line 693. The commented-out code will be uncommented, and the indentation will be adjusted to match the surrounding code.

SU2_CFD/src/integration/CIntegration.cpp

+  // BEGIN_SU2_OMP_SAFE_GLOBAL_ACCESS {
+  //   if (config->GetBoolTurbomachinery()){
+  //       /*--- Average quantities at the inflow and outflow boundaries ---*/
+  //     solver_container[MainSolver]->TurboAverageProcess(solver_container, geometry,config,INFLOW);
+  //     solver_container[MainSolver]->TurboAverageProcess(solver_container, geometry, config, OUTFLOW);
+  //   }
+  // }
+  // END_SU2_OMP_SAFE_GLOBAL_ACCESS


To fix the issue, we need to either remove the commented-out code entirely or reinstate it into the program. Since there is no explicit indication that this code is obsolete, and it appears to be part of a specific functionality (SU2_OMP_SAFE_GLOBAL_ACCESS), the best course of action is to reinstate the code. This will ensure that the functionality is preserved and can be tested and maintained as part of the codebase. If the functionality is not currently needed, it can be conditionally compiled using preprocessor directives (e.g., #ifdef) to avoid confusion while keeping the code accessible for future use.

The changes will involve uncommenting the block of code between // BEGIN_SU2_OMP_SAFE_GLOBAL_ACCESS and // END_SU2_OMP_SAFE_GLOBAL_ACCESS and ensuring that it integrates correctly with the surrounding code.

SU2_CFD/src/iteration/CDiscAdjFluidIteration.cpp

+      //   CGeometry::ComputeWallDistance(config, geometry);
+      // }


To resolve the issue, we need to either remove the commented-out code or reinstate it into the codebase. Since the surrounding comments suggest that the code might be part of a turbo simulation workflow, we should carefully evaluate whether the commented-out code is still relevant. If it is, we should reinstate it; otherwise, we should remove it entirely.

In this case, the commented-out code does not appear to be actively used or necessary for the current implementation. Therefore, the best course of action is to remove the commented-out code to improve readability and maintainability.

Fixes from tagging tool

98989f7

joshkellyjak added PR: draft changelog:feature labels Feb 18, 2025

Config catch + fix preacc in ComputeVorticityandStrainMag

6082eac

oleburghardt mentioned this pull request Feb 19, 2025

[WIP] Multizone discrete adjoints for turbomachinery #2317

Closed

pcarruscag reviewed Feb 20, 2025

View reviewed changes

Initial add turbo obj functions

b3267b6

joshkellyjak mentioned this pull request Feb 25, 2025

Update CTurbSSTSolver.cpp to fix bug on calculating MuT #2453

Merged

6 tasks

Joshua Kelly and others added 6 commits March 11, 2025 16:24

Initial refactoring of turboperformance into solver for correct recor…

c459ce9

…ding of objective function calculation

Resolve preaccumulation error in SetRoe_Dissipation_FD.

4963a99

Add RegisterContainer for active vectors.

cc1de15

Compatibility with develop.

48e519f

Add eddy viscosity as recording input/output of RANS solvers.

ddc7ab4

Move registration of muT for RANS to new RegisterComplementary.

f77a773

oleburghardt mentioned this pull request Mar 21, 2025

Fix preaccumulation error, improve recording of RANS solvers #2472

Merged

6 tasks

Joshua Kelly added 2 commits March 21, 2025 13:06

Merge remote-tracking branch 'origin/fix_small_AD_issues' into featur…

4a58b8c

…e_mz_turbomachinery_adjoint

Adding geometry to AD recording for turbo calcs. (NOT WORKING CURRENTLY)

1614784

github-advanced-security bot found potential problems May 1, 2025

View reviewed changes

SU2_CFD/src/iteration/CDiscAdjFluidIteration.cpp Fixed Show fixed Hide fixed

SU2_CFD/src/iteration/CTurboIteration.cpp Fixed Show fixed Hide fixed

SU2_CFD/src/solvers/CEulerSolver.cpp Fixed Show fixed Hide fixed

Singlezone working with validated gradients and turbo obj funcs. Need…

d43fef5

… to run in quasi-MZ approach. (NEEDS CLEANING)

github-advanced-security bot found potential problems Jun 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Multizone adjoints for turbomachinery #2446

[WIP] Multizone adjoints for turbomachinery #2446

joshkellyjak commented Feb 18, 2025

Uh oh!

pcarruscag Feb 20, 2025

Uh oh!

pcarruscag Feb 20, 2025

Uh oh!

pcarruscag Feb 20, 2025

Uh oh!

joshkellyjak Feb 20, 2025

Uh oh!

oleburghardt Mar 25, 2025 •

edited

Loading

Uh oh!

pcarruscag Feb 20, 2025

Uh oh!

joshkellyjak Feb 20, 2025

Uh oh!

pcarruscag Feb 20, 2025

Uh oh!

joshkellyjak Feb 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Uh oh!

		AD::EndPreacc();

		/--- Max is not differentiable, so we not register them for preacc. ---/

	SU2_MPI::Error(string("OUTPUT_WRT_FREQ cannot be specified for this solver "
	SU2_MPI::Error("OUTPUT_WRT_FREQ cannot be specified for this solver "

		"(writing of restart and sensitivity files not possible for multizone discrete adjoint during runtime yet).\n"
		"Please remove this option from the config file, output files will be written when solver finalizes.\n"), CURRENT_FUNCTION);

[WIP] Multizone adjoints for turbomachinery #2446

Are you sure you want to change the base?

[WIP] Multizone adjoints for turbomachinery #2446

Conversation

joshkellyjak commented Feb 18, 2025

Proposed Changes

Related Work

PR Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oleburghardt Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Uh oh!

oleburghardt Mar 25, 2025 •

edited

Loading