This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Index and purge peers by petname + rework follow / unfollow lifecycle #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
force-pushed
the
2023-11-08-index-peer-by-petname
branch
from
d37f015 to
bc771d6
Compare
bfollington
commented
Nov 13, 2023
bfollington
commented
Nov 13, 2023
bfollington
commented
Nov 13, 2023
xcode/Subconscious/Shared/Components/Common/Byline/PetnameView.swift
Outdated
Show resolved
Hide resolved
bfollington
commented
Nov 13, 2023
xcode/Subconscious/Shared/Components/Common/Profile/UserProfileView.swift
Outdated
Show resolved
Hide resolved
bfollington
commented
Nov 13, 2023
bfollington
commented
Nov 13, 2023
bfollington
commented
Nov 13, 2023
bfollington
commented
Nov 13, 2023
bfollington
changed the title
gordonbrander
approved these changes
Nov 13, 2023
xcode/Subconscious/Shared/Components/Common/Byline/PetnameView.swift
Outdated
Show resolved
Hide resolved
| guard self.state == .ready else { | ||
| throw DatabaseServiceError.notReady | ||
| } | ||
| let savepoint = "purge" | ||
|
|
||
| guard let peer = try readPeer(petname: petname) else { |
There was a problem hiding this comment.
Is this guard clause necessary? If we delete a peer, but there are no peers with that name, the end result should be the same.
There was a problem hiding this comment.
We need to know the DID of a peer to delete from the memos table, which we can only get by reading the peer.
|
@bfollington one more note: the animations for refreshing profile seem wonky, especially around the feed (seems to animate from the bottom?) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #989
Fixes #946
Fixes #977
This PR remodels the follow/unfollow/rename operations and refresh lifecycle. It also introduces support for indexing multiple peers that point to the same DID.
Screen.Recording.2023-11-13.at.1.04.23.pm.mov
I intend to refactor the "wait for petname resolution" logic and background jobs in general as a follow up in #996
Tasks