-
Notifications
You must be signed in to change notification settings - Fork 46
feat: generate m4b audiobook from files #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution! The barrier to entry is pretty low over here and the project isn't all that active, so my code quality standards aren't going to be all that stringent. I'll give this a test, see if there are any low-hanging-fruit for quality improvements, and get back to you. |
|
I see, this is mainly just some wrapping around ffmpeg. I feel like this is a bit out of scope for the project, but since you want it, I'd be happy to try to include it. I may switch to https://pypi.org/project/pyffmpeg/ to improve the install experience for non-docker users. Bundling the pyexe is probably going to break too, so that might prevent me from accepting this contribution, but I'll give it a shot. |
|
On second thought, I may just leave the ffmpeg install as an exercise for the user if they want this feature, which is what you did. That seems quite reasonable. |
Hey! Sorry for answering a bit late. I have no issues in removing the |
|
I'd still like to include these features, hopefully in the next release of |
This is a proof of concept to improve audiobook download by:
cover.jpgfiles.txtwith the list of mp3 files downloadedmetadata.txtwith metadata and chapter informationSeriesandSeriesNumberto name formatting--generate-audiobookflag tobook getcommand to run someffmpegcommands to generate am4bbundle file with the cover, metadata and chapter information from kobo. Obviously this requiresffmpegto be present in the system.ffmpegto theDockerfileLet me know what you think and what guidelines should I follow to leave this to the finish line. I have been out of the python world for years so I'm a bit rusty.