Skip to content

deps: upgrade express middleware and clean outdated dependencies - #1876

Merged
sublime247 merged 1 commit into
sublime247:mainfrom
Gabbydunkk:upgrade-express-cleanup-1849
Aug 27, 2026
Merged

deps: upgrade express middleware and clean outdated dependencies#1876
sublime247 merged 1 commit into
sublime247:mainfrom
Gabbydunkk:upgrade-express-cleanup-1849

Conversation

@Gabbydunkk

Copy link
Copy Markdown
Contributor

Summary

Upgrades the Express middleware stack and cleans outdated/unused dependencies:

  • express ^4.18.2^4.22.2 — latest 4.x line, pulling in the security fixes shipped in 4.19–4.22. A jump to Express 5 is currently blocked by apollo-server-express@3.13's hard peer dependency on express@^4.17.1 (verified: npm install fails with ERESOLVE), and migrating GraphQL to @apollo/server is a separate refactor well beyond this dependency pass.
  • connect-redis ^7.1.1^10.0.0 — current line, whose peers (redis >=5, express-session >=1) match what the repo already uses. Updated src/config/redis.ts to the v10 named export (RedisStore) and the two jest mocks that shape it.
  • Removed dead dependencies:
    • spdy — the app serves over Node's native http2; only stale test mocks referenced it.
    • pino-loki — unused anywhere.
  • Removed the now-unneeded spdy mocks from paymentLink and multisigCallbacks tests.

Verification

  • npm install resolves cleanly (no peer conflicts)
  • npm run type-check — clean
  • npm run build — clean
  • npm run lint — 0 errors
  • npx prettier --check on all touched files — clean
  • Affected test suites behave identically to main (the remaining failures in paymentLink/multisigCallbacks/kycUpload are pre-existing fallout from the recent BullMQ migration — they fail on a clean checkout of main too and are unrelated to this change; the repo's CI test step runs with continue-on-error: true).
  • Runtime smoke: RedisStore from connect-redis v10 constructs correctly with the repo's redis v5 client and prefix option.

Closes #1849

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@Gabbydunkk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Gabbydunkk
Gabbydunkk force-pushed the upgrade-express-cleanup-1849 branch from 1876ae1 to 39025a4 Compare August 26, 2026 22:44
- express ^4.18.2 -> ^4.22.2 (latest 4.x line, includes the security
  fixes shipped in 4.19-4.22). A full Express 5 jump is blocked by
  apollo-server-express@3's hard peer on express@^4.17.1; migrating
  GraphQL to @apollo/server is out of scope for this dependency pass.
- connect-redis ^7.1.1 -> ^10.0.0 (current line, peers redis>=5 and
  express-session>=1 which the repo already uses); updated the import to
  the v10 named export and the two jest mocks accordingly.
- Remove dead dependencies: spdy (app uses native http2; only stale test
  mocks referenced it) and pino-loki (unused).
- Drop the now-unneeded spdy mocks from paymentLink and multisigCallbacks
  tests.

Type-check, build and lint are clean; the affected test suites behave
identically to main (remaining failures are pre-existing fallout from the
recent BullMQ migration, unrelated to this change).

Closes sublime247#1849

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
@Gabbydunkk
Gabbydunkk force-pushed the upgrade-express-cleanup-1849 branch from 5cc4417 to c0837d6 Compare August 26, 2026 22:54
@Gabbydunkk Gabbydunkk closed this Aug 26, 2026
@Gabbydunkk Gabbydunkk reopened this Aug 26, 2026
@sublime247
sublime247 merged commit 7a9ced2 into sublime247:main Aug 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] Upgrade Express.js middleware and clean outdated dependencies

2 participants