deps: upgrade express middleware and clean outdated dependencies - #1876
Merged
sublime247 merged 1 commit intoAug 27, 2026
Merged
Conversation
|
@Gabbydunkk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Gabbydunkk
force-pushed
the
upgrade-express-cleanup-1849
branch
from
August 26, 2026 22:44
1876ae1 to
39025a4
Compare
- express ^4.18.2 -> ^4.22.2 (latest 4.x line, includes the security fixes shipped in 4.19-4.22). A full Express 5 jump is blocked by apollo-server-express@3's hard peer on express@^4.17.1; migrating GraphQL to @apollo/server is out of scope for this dependency pass. - connect-redis ^7.1.1 -> ^10.0.0 (current line, peers redis>=5 and express-session>=1 which the repo already uses); updated the import to the v10 named export and the two jest mocks accordingly. - Remove dead dependencies: spdy (app uses native http2; only stale test mocks referenced it) and pino-loki (unused). - Drop the now-unneeded spdy mocks from paymentLink and multisigCallbacks tests. Type-check, build and lint are clean; the affected test suites behave identically to main (remaining failures are pre-existing fallout from the recent BullMQ migration, unrelated to this change). Closes sublime247#1849 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Gabbydunkk
force-pushed
the
upgrade-express-cleanup-1849
branch
from
August 26, 2026 22:54
5cc4417 to
c0837d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the Express middleware stack and cleans outdated/unused dependencies:
^4.18.2→^4.22.2— latest 4.x line, pulling in the security fixes shipped in 4.19–4.22. A jump to Express 5 is currently blocked byapollo-server-express@3.13's hard peer dependency onexpress@^4.17.1(verified:npm installfails withERESOLVE), and migrating GraphQL to@apollo/serveris a separate refactor well beyond this dependency pass.^7.1.1→^10.0.0— current line, whose peers (redis >=5,express-session >=1) match what the repo already uses. Updatedsrc/config/redis.tsto the v10 named export (RedisStore) and the two jest mocks that shape it.spdy— the app serves over Node's nativehttp2; only stale test mocks referenced it.pino-loki— unused anywhere.spdymocks frompaymentLinkandmultisigCallbackstests.Verification
npm installresolves cleanly (no peer conflicts)npm run type-check— cleannpm run build— cleannpm run lint— 0 errorsnpx prettier --checkon all touched files — cleanmain(the remaining failures inpaymentLink/multisigCallbacks/kycUploadare pre-existing fallout from the recent BullMQ migration — they fail on a clean checkout ofmaintoo and are unrelated to this change; the repo's CI test step runs withcontinue-on-error: true).RedisStorefrom connect-redis v10 constructs correctly with the repo'sredisv5 client andprefixoption.Closes #1849