1780 bug correct cors configuration on admin route group - #1895
Merged
sublime247 merged 2 commits intoAug 28, 2026
Conversation
|
@OluwapelumiElisha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the CORS configuration applied to the admin route group, resolving issues where the admin dashboard was blocked by the global exact-match CORS configuration.
Previously,
applySecurityMiddlewareutilized a strict exact-matchcors()implementation which only checked staticALLOWED_ORIGINS. Additionally, the globalOPTIONSpreflight handler intercepted all preflight requests, blocking administrative domains dynamically defined inCORS_ALLOWED_ORIGINS.This PR corrects this behavior by explicitly applying the configurable
createCorsMiddleware()(which readscors.allowedOriginsandCORS_ALLOWED_ORIGINS) to all/api/adminprefixed routes. It also updates the globalapplySecurityMiddlewareto correctly bypass its static CORS handlers (includingOPTIONSpreflight checks) for any request routed to the admin group.Changes Made
applySecurityMiddlewareinsrc/config/express.tsto skip its staticcors(corsOptions)andapp.options("*")processing for paths starting with/api/admin.app.use("/api/admin", createCorsMiddleware());insrc/index.tsto seamlessly apply the dynamically configurable CORS allowlist specifically for admin-related requests.Related Issues
Fixes #1780