Skip to content

test: add verification scenarios for multi-signature auth flows - #1898

Merged
sublime247 merged 1 commit into
sublime247:mainfrom
pyper01:test/multisig-auth-verification-scenarios
Aug 28, 2026
Merged

test: add verification scenarios for multi-signature auth flows#1898
sublime247 merged 1 commit into
sublime247:mainfrom
pyper01:test/multisig-auth-verification-scenarios

Conversation

@pyper01

@pyper01 pyper01 commented Aug 27, 2026

Copy link
Copy Markdown

Summary

This PR adds comprehensive verification scenarios for multi-signature auth flows in multisigCallbacks.

Closes #1843


Detailed Summary of Changes

  • Updated src/routes/__tests__/multisigCallbacks.test.ts:
    • Added test case verifying rejection with 400 when required payload fields are missing.
    • Added test case verifying rejection with 401 when a signer is marked inactive (is_active: false) in configuration.
    • Added test case verifying partial signature threshold progression (status remains pending_signatures and payout execution is not triggered until threshold is met).
    • Added test case verifying rejection with 400 when duplicate signatures are submitted by the same signer.

- Add test coverage for missing required payload fields (400)
- Add verification scenario rejecting inactive signers (401)
- Add verification scenario for partial signature threshold progression
- Add verification scenario for duplicate signature rejection (400)
@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@pyper01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@sublime247
sublime247 merged commit f1c4cc4 into sublime247:main Aug 28, 2026
14 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Testing] Add verification scenarios for multi-signature auth flows

2 participants