[JavaScript] Fix pre-mature termination of for loops in TypeScript - #4593
Merged
deathaxe merged 2 commits intoJul 28, 2026
Merged
Conversation
This commit makes sure `expression-begin` is pushed onto stack after `<` in both `postfix-operators` and `ts-less-than` contexts. The latter was popping before, which terminated a comparison expression too early. Re-use JavaScript related control structure syntax tests to verify TypeScript behaving equally.
This commit copies syntax_test_js_control.js to verify JSX/TSX behaving equally.
michaelblyons
approved these changes
Jul 28, 2026
michaelblyons
left a comment
michaelblyons
left a comment
Collaborator
There was a problem hiding this comment.
Lines of code change: 1
Lines of test change: 570 × 3
😆
jrappen
approved these changes
Jul 28, 2026
|
I haven't verified but it sounds like this also fixes: for (let i = 0; i < argv.length; i++) {
//
}
? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4592
This PR makes sure
expression-beginis pushed onto stack after<in bothpostfix-operatorsandts-less-thancontexts. The latter was popping before, which terminated a comparison expression too early.Re-use JavaScript related control structure syntax tests to verify TypeScript behaving equally.