Skip to content

Conversation

@ismell
Copy link
Contributor

@ismell ismell commented Dec 22, 2025

This CL adds the Android Syntax package.

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • [N/A] Any commands are available via the command palette.
  • [N/A] Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is Android Syntax

There are no packages like it in Package Control.

@github-actions
Copy link

Package Review

Channel Diff

Removed (none), changed (none), added Android Syntax.

Review for Android Syntax 1.0.0

No failures

4 warnings:
- '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    File: SELinux.context.sublime-syntax
- '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    File: SELinux.te.sublime-syntax
- '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    File: init.rc.sublime-syntax
- '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    File: Android.bp.sublime-syntax


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

This CL adds the Android Syntax package.
@github-actions
Copy link

Package Review

Channel Diff

Removed (none), changed (none), added Android Syntax.

Review for Android Syntax 1.0.0

No failures

4 warnings:
- '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    File: SELinux.context.sublime-syntax
- '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    File: SELinux.te.sublime-syntax
- '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    File: init.rc.sublime-syntax
- '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    File: Android.bp.sublime-syntax


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

@braver
Copy link
Collaborator

braver commented Jan 10, 2026

Looks good, just some questions:

  • Why is the one scope source.selinux.contexts different from the others? Typically a structure like this suggests that source.selinux also exists, but it doesn't.
  • Instead of putting the Apache license inside each file, just let the LICENSE file in the repo cover it.
  • You might want to put your test files in a directory.
  • Did you (or the agent you use) also run those tests?

@braver braver added the feedback provided The changes and package have been seen by a reviewer label Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants