Skip to content

Conversation

@klmp200
Copy link
Contributor

@klmp200 klmp200 commented Dec 27, 2025

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package adds an interactive code map that helps visualise and navigate through symbols on files.

My package is similar to sublime-codemap However it should still be added because it uses modern sublime API. It's design is very different and allows for live update while avoiding navigation bugs.

@github-actions
Copy link

Package Review

Channel Diff

Removed (none), changed (none), added NeoCodeMap.

Review for NeoCodeMap 1.0.0

No failures

4 warnings:
- Command class 'ToggleNeoCodeMap' does not end with 'Command'
    File: NeoCodeMap.py
    Line: 265, Column: 1
- Command class 'CloseAllNeoCodeMap' does not end with 'Command'
    File: NeoCodeMap.py
    Line: 270, Column: 1
- Command class 'GotoViewRegionNeoCodeMap' does not end with 'Command'
    File: NeoCodeMap.py
    Line: 275, Column: 1
- Found multiple command prefixes: Close, Goto, Toggle. Consider using one single prefix so as to not clutter the command namespace.


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

@github-actions
Copy link

Package Review

Channel Diff

Removed (none), changed (none), added NeoCodeMap.

Review for NeoCodeMap 1.0.0

No failures

1 warnings:
- Found multiple command prefixes: Code, Neo. Consider using one single prefix so as to not clutter the command namespace.


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

@github-actions
Copy link

Package Review

Channel Diff

Removed (none), changed (none), added NeoCodeMap.

Review for NeoCodeMap 1.0.0

No failures

No warnings


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

@braver
Copy link
Collaborator

braver commented Jan 21, 2026

Cool, so this is like a modern re-interpretation of the CodeMap package?

I'm going to copy over some comments about loading settings that I posted for a different PR:

In general, avoid loading the settings on package load. You want to catch any changes a user makes to the setting, and now you need to add an on change listener, and and unload method... If you just load the settings whenever you need them, that will be instant anyway. There is no performance concern to worry about (in fact your listener is probably detrimental), settings are served from memory, and Sublime already handles changes in the background seamlessly. Just load settings on the fly (example) and your code can be simplified and made more reliable and performant.

In short, unless you have very specific needs load settings on the fly as needed.

Beyond that though, looks really well done 👌🏻

@braver braver added feedback provided The changes and package have been seen by a reviewer mergeable The channel changes are good but some action from the author is still needed labels Jan 21, 2026
@klmp200
Copy link
Contributor Author

klmp200 commented Jan 21, 2026

Yes, this is precisely modern re-interpretation of the CodeMap package.

I had some issues with it, fixed a few things but I wasn't happy with how it was breaking my cursor position history. I decided to try something new instead.

I'm glad you like it, I'll work on a fix following your advices. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer mergeable The channel changes are good but some action from the author is still needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants