Remove IP label from DNS query metrics#2028
Remove IP label from DNS query metrics#2028tpantelis wants to merge 1 commit intosubmariner-io:develfrom
Conversation
Remove the destination_service_ip label to reduce metrics cardinality. Each unique IP creates a separate time series, leading to unbounded cardinality in dynamic environments with pod scaling and restarts. Service-level aggregation should be sufficient for monitoring use cases. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
|
🤖 Created branch: z_pr2028/tpantelis/rem_ip_label |
WalkthroughThe changes remove the destination service IP label from DNS query metrics across the CoreDNS plugin. The metric now tracks four labels instead of five: source cluster, destination cluster, destination service name, and destination service namespace. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Remove the destination_service_ip label to reduce metrics cardinality. Each unique IP creates a separate time series, leading to unbounded cardinality in dynamic environments with pod scaling and restarts. Service-level aggregation should be sufficient for monitoring use cases.
Summary by CodeRabbit