Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement conversion for recently added types to proto and back #124

Merged
merged 5 commits into from
Mar 7, 2025

Conversation

EpsilonPrime
Copy link
Member

No description provided.

@EpsilonPrime EpsilonPrime requested a review from scgkiran March 7, 2025 10:24
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.05%. Comparing base (32ce783) to head (8d6bb49).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
types/types.go 86.95% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   63.94%   64.05%   +0.10%     
==========================================
  Files          44       44              
  Lines       10940    10989      +49     
==========================================
+ Hits         6996     7039      +43     
- Misses       3629     3632       +3     
- Partials      315      318       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EpsilonPrime EpsilonPrime merged commit e6df514 into substrait-io:main Mar 7, 2025
8 checks passed
@EpsilonPrime EpsilonPrime deleted the precision_fixes branch March 7, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants