Skip to content

Conversation

@lorenarosati
Copy link
Contributor

@lorenarosati lorenarosati commented Aug 11, 2025

When creating a literal of type IntervalDayToSecond with the NewLiteral() function, the final returned literal did not have the precision set to the correct precision for its type (its value had a different precision than its type).

See this issue: #145

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.62%. Comparing base (74376f6) to head (a16e507).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   65.61%   65.62%           
=======================================
  Files          45       45           
  Lines       11625    11626    +1     
=======================================
+ Hits         7628     7629    +1     
  Misses       3668     3668           
  Partials      329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vbarua vbarua changed the title Precision not set properly for IntervalDayToSecond literal fix: set Precision on IntervalDayToSecond literals Aug 14, 2025
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this 🙇

@vbarua vbarua merged commit b96ca33 into substrait-io:main Aug 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants