feat: add EmptyVirtualTable to Builder interface #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Builder interface has new EmptyVirtualTable method
vbarua
commented
Sep 22, 2025
| case *proto.ReadRel_VirtualTable_: | ||
| if len(readType.VirtualTable.Values) > 0 && len(readType.VirtualTable.Expressions) > 0 { | ||
| return nil, fmt.Errorf("VirtualTable Value can't have both liternal and expression") | ||
| return nil, fmt.Errorf("VirtualTable cannot declare both Values and Expressions") |
There was a problem hiding this comment.
Opportunistic error message clarification
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 66.35% 67.76% +1.41%
==========================================
Files 45 45
Lines 11688 12098 +410
==========================================
+ Hits 7755 8198 +443
+ Misses 3602 3562 -40
- Partials 331 338 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adam-Alani
approved these changes
Sep 24, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
bvolpato
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Builder interface has new EmptyVirtualTable method