- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25
 
feat(plan): Support Create Table As Select #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* add NamedTableWriteRel type * add CreateTableAsSelect() in builder
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   54.53%   54.71%   +0.17%     
==========================================
  Files          35       35              
  Lines        8006     8115     +109     
==========================================
+ Hits         4366     4440      +74     
- Misses       3441     3474      +33     
- Partials      199      201       +2     ☔ View full report in Codecov by Sentry.  | 
    
| ], | ||
| "version": { | ||
| "majorNumber": 0, | ||
| "minorNumber": 29, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: Every time we bump the protocol version we'll need to update this file although it doesn't necessarily affect anything. That may be fine as it may prompt us to double check this file's construction but I suspect it'll be a nuisance. Does checkRoundTrip depend on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EpsilonPrime Yes, checkRoundTrip depends on this.
add NamedTableWriteRel type
add CreateTableAsSelect() in builder