Skip to content

Conversation

@srikrishnak
Copy link
Contributor

  • add NamedTableWriteRel type

  • add CreateTableAsSelect() in builder

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

* add NamedTableWriteRel type

* add CreateTableAsSelect() in builder
@srikrishnak srikrishnak changed the title DRAFT: feat(plan): Support Create Table As Select feat(plan): Support Create Table As Select Oct 31, 2024
@srikrishnak srikrishnak marked this pull request as ready for review October 31, 2024 05:37
@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 61.94690% with 43 lines in your changes missing coverage. Please review.

Project coverage is 54.71%. Comparing base (9cb5896) to head (18aa6c7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
plan/relations.go 59.64% 22 Missing and 1 partial ⚠️
plan/plan.go 75.00% 7 Missing and 1 partial ⚠️
plan/builders.go 63.15% 5 Missing and 2 partials ⚠️
expr/field_reference.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   54.53%   54.71%   +0.17%     
==========================================
  Files          35       35              
  Lines        8006     8115     +109     
==========================================
+ Hits         4366     4440      +74     
- Misses       3441     3474      +33     
- Partials      199      201       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

],
"version": {
"majorNumber": 0,
"minorNumber": 29,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Every time we bump the protocol version we'll need to update this file although it doesn't necessarily affect anything. That may be fine as it may prompt us to double check this file's construction but I suspect it'll be a nuisance. Does checkRoundTrip depend on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EpsilonPrime Yes, checkRoundTrip depends on this.

@zeroshade zeroshade merged commit 1a7a92c into substrait-io:main Nov 1, 2024
8 checks passed
@srikrishnak srikrishnak deleted the ctas branch November 4, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants